Steps to Reproduce:
Adding Sign with MFA and another action into an edit in a task and text something in it, then submit that text without changing previous status of the action added.
Actual Results:
It will show a dialog titiled 'Actions With No Effect', and after choosing to apply, it turns to MFA verification. However, the previous dialog will be shown again after MFA verification so that the text could be submitted.
Expected Results: Text were sent successfully with no other actions
Thanks for reporting this!
By "edit in a task", I assume you mean the "Add Action..." dropdown and not the "Edit Task" option? If so, confirming:
Steps:
Post as Comment
The actions you are taking have no effect:
Edges already exist; transaction has no effect.
You can not sign a transaction group that has no other effects.
Do you want to post your comment anyway?Expected outcome:
Comment added.
Actual outcome:
Get the dialog from step 5 again
CONFIRMED. And please note that not only action 'Change Project Tags' will cause this. As far ad I know, Change Priority will also cause.
Yep, this reproduces for me. (Although I think the behavior is an infinite loop of prompts, not just "twice"?)
The "You can not sign a transaction group that has no other effects." logic should not be triggering when the change includes confirmable actions like comments. I'll fix this.
Actually, it is indeed an infinite loop in my opinion.
And I think we could also have a cross button to delete added actions on portable devices, like on PC, if this advice could be posted and discussed here.
@Hamishcn: Please feel free to file unrelated requests as specific separate tasks. Thanks!
Closing as per last comment as a more recent software version is now deployed on phabricator.wikimedia.org.
If this is still a problem, then please set the status of this report back to "Open" via the Add Action... → Change Status dropdown. Thanks!