Page MenuHomePhabricator
Create Task
Maniphest T224749

OAuth consumer id should be exposed
Open, Needs TriagePublic
Actions

Description

OAuth change tags have the form OAuth CID: <id>. This is the autoincrement ID of the DB record, not the usual consumer key, and it does not seem to be exposed anywhere, so if I want to filter for changes from some specific consumer, I have to look it up in the DB. There is no reason not to display it publicly.

Details

SubjectRepoBranchLines +/-
Add recenchanges link to consumer detail viewmediawiki/extensions/OAuthmaster+8 -0
Expose consumer ID to the UImediawiki/extensions/OAuthmaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.May 31 2019, 6:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2019, 6:54 PM
Ammarpad subscribed.EditedMar 13 2020, 3:48 PM

Special:OAuthListConsumers, Special:OAuthManageMyGrants seem to be good spots for this. Is that OK?

Tgr added a comment.Mar 13 2020, 8:27 PM

Wrt. "I want to filter for changes from some specific consumer", I think I added direct links for that at some point (c513737 / c513736). Still probably worthwhile to do.

In T224749#5967572, @Ammarpad wrote:

Special:OAuthListConsumers, Special:OAuthManageMyGrants seem to be good spots for this. Is that OK?

Agreed.

gerritbot added a comment.Mar 16 2020, 11:03 AM

Change 579911 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/OAuth@master] Expose consumer ID to the UI

https://gerrit.wikimedia.org/r/579911

gerritbot added a project: Patch-For-Review.Mar 16 2020, 11:03 AM
Tgr mentioned this in T247800: (partially) expose oauth_registered_consumer table.Mar 17 2020, 8:30 AM
gerritbot added a comment.Feb 28 2021, 5:23 AM

Change 579911 abandoned by Ammarpad:
[mediawiki/extensions/OAuth@master] Expose consumer ID to the UI

Reason:

https://gerrit.wikimedia.org/r/579911

Pppery removed a project: Patch-For-Review.Apr 1 2023, 4:12 PM
Ragesoss subscribed.Jul 21 2023, 8:22 PM
gerritbot added a comment.Jul 24 2023, 2:29 AM

Change 940509 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/OAuth@master] Add recenchanges link to consumer detail view

https://gerrit.wikimedia.org/r/940509

gerritbot added a project: Patch-For-Review.Jul 24 2023, 2:29 AM
gerritbot added a comment.Jul 24 2023, 5:51 PM

Change 940509 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] Add recenchanges link to consumer detail view

https://gerrit.wikimedia.org/r/940509

Ragesoss added a comment.Jul 24 2023, 5:52 PM

🎸 rad! thanks @Tgr !

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Jul 24 2023, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 24 2023, 6:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL