Page MenuHomePhabricator
Create Task
Maniphest T224765

Add phan to OpenStackManager extension
Closed, ResolvedPublic
Actions

Description

As wmf deployed extension the OpenStackManager extension should run phan on CI to found simple bugs in an earlier state of development.

OpenStackManager extension is not using the common /includes/ or /src/ folder, which makes the config for phan a bit harder.

Details

SubjectRepoBranchLines +/-
build: Add mediawiki/mediawiki-phan-configmediawiki/extensions/OpenStackManagermaster+150 -59
layout: [OpenStackManager] Enable Phanintegration/configmaster+1 -0
[OpenStackManager] Add phan dependencyintegration/configmaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.May 31 2019, 8:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2019, 8:42 PM
Umherirrender updated the task description. (Show Details)May 31 2019, 8:48 PM
Umherirrender added a parent task: T224783: Enable mediawiki/mediawiki-phan-config on all Wikimedia-deployed repositories.May 31 2019, 9:39 PM
Daimona moved this task from Backlog to Extensions on the phan board.Sep 12 2019, 5:49 PM
gerritbot added a comment.Oct 13 2019, 3:13 PM

Change 542760 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[integration/config@master] [OpenStackManager] Add phan dependency

https://gerrit.wikimedia.org/r/542760

gerritbot added a project: Patch-For-Review.Oct 13 2019, 3:13 PM
gerritbot added a comment.Oct 13 2019, 3:32 PM

Change 542762 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/OpenStackManager@master] build: Add mediawiki/mediawiki-phan-config

https://gerrit.wikimedia.org/r/542762

Umherirrender claimed this task.Oct 13 2019, 3:33 PM
Umherirrender triaged this task as Medium priority.
gerritbot added a comment.Oct 15 2019, 4:45 PM

Change 542760 merged by jenkins-bot:
[integration/config@master] [OpenStackManager] Add phan dependency

https://gerrit.wikimedia.org/r/542760

gerritbot added a comment.Oct 15 2019, 5:37 PM

Change 543182 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [OpenStackManager] Enable Phan

https://gerrit.wikimedia.org/r/543182

gerritbot added a comment.Oct 15 2019, 6:00 PM

Change 543182 merged by jenkins-bot:
[integration/config@master] layout: [OpenStackManager] Enable Phan

https://gerrit.wikimedia.org/r/543182

Stashbot added a comment.Oct 15 2019, 6:01 PM

Mentioned in SAL (#wikimedia-releng) [2019-10-15T18:01:41Z] <James_F> Zuul: Enable Phan for OpenStackManager T224765

gerritbot added a comment.Oct 15 2019, 6:29 PM

Change 542762 merged by jenkins-bot:
[mediawiki/extensions/OpenStackManager@master] build: Add mediawiki/mediawiki-phan-config

https://gerrit.wikimedia.org/r/542762

Umherirrender closed this task as Resolved.Oct 15 2019, 6:40 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 15 2019, 7:19 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.3; 2019-10-22).Oct 15 2019, 8:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL