Page MenuHomePhabricator

Don't show UserFeedBack form on non-existent pages
Closed, ResolvedPublic

Description

Current behaviour:
Going to a non-existent page shows a feedback form
Example: https://www.mediawiki.org/wiki/API:Message

Expected behaviour:
Going to a non-existent page should not show a feedback form

Recently enabled on mediawiki in T225584, could have been an issue earlier on wikitech

Event Timeline

Restricted Application added a project: User-DannyS712. · View Herald TranscriptJun 22 2019, 2:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper added a subscriber: srishakatux.

Thanks for reporting this! That's a gadget and nothing in MediaWiki code, hence removing the MediaWiki tag here.
Also note that gadget issues are not tracked in Phabricator until there is a dedicated project or it's on the to-do list of a team.
This might be better suited on https://www.mediawiki.org/wiki/MediaWiki_talk:Gadget-userfeedback.js up to the maintainer (@srishakatux) to decide...

I'd simply change the condition to

if ( action !== 'view' ||
    namespace.indexOf( supportedNamespaces ) === -1 ||
    mw.config.get( 'wgArticleId' ) === 0 ||
    isTalkPage ) {

but of course I cannot edit https://www.mediawiki.org/wiki/MediaWiki:Gadget-userfeedback.js ... sigh.

Fixed on wikitech using a variation of the fix suggested by @Aklapper in T226296#5275651

Thanks @DannyS712 for reporting this! After testing the changes @bd808 has made to the script, I will request the interface admins to replicate the same on MediaWiki.

Testing complete. @Wargo @Tomybrz Please help replicate the changes on MediaWiki.org.

DannyS712 closed this task as Resolved.Jun 30 2019, 7:20 PM
DannyS712 assigned this task to Wargo.
DannyS712 moved this task from Unsorted to Resolved tasks (others) on the User-DannyS712 board.