Page MenuHomePhabricator
Create Task
Maniphest T227907

[Bug] mobile-html: DOMRect object from InteractionHandler response cannot be decoded on iOS
Closed, ResolvedPublic
Actions

Description

Steps to Reproduce

  1. Build & run iOS mobile-html prototype https://github.com/wikimedia/wikipedia-ios-lite (master)
  2. Open any article
  3. Tap any reference

Expected Results

  • App doesn't crash

Actual Results

  • App crashes

Environments Observed

  • Prod

Additional notes

  • It looks like iOS is unable to decode DOMRect object that's included in ReferenceItem. DOMRect behaves differently than plain JS objects - for example, calling Object.keys(someDOMRectObject) will return an empty array. Node 12.3.1 has a toJSON() method that converts DOMRect objects into plain JS objects but since the page library is still on 10.16.0, we can't use it. We could create a plain object using DOMRect's keys and values.

Related Objects

Event Timeline

• NHarateh_WMF created this task.Jul 12 2019, 6:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2019, 6:21 PM
• bearND subscribed.Jul 12 2019, 6:24 PM

We left that out since we wanted to have something platform agnostic. Is there a way you could do the conversion to whatever is needed on the iOS native side?

• NHarateh_WMF added a comment.Jul 12 2019, 6:31 PM

@bearND Unfortunately, no. iOS is doing all the decoding of JS messages and I'm just getting a dictionary with the result. There's no way for me to get raw JS and implement decoding on my own on the native side.

• bearND added a comment.Jul 12 2019, 6:34 PM

@NHarateh_WMF where in the iOS app or lite app code is this used so I can better understand this?

• NHarateh_WMF added a comment.Jul 12 2019, 6:37 PM

@bearND

This is the object we're using to register InteractionHandler and receive interaction messages: https://github.com/wikimedia/wikipedia-ios-lite/blob/55ba227f2db2a9a815319d032d6129ea75669481/lite/WKUserScripts/InteractionSetupUserScript.swift#L3

This is what gets called whenever iOS receives a JS message & decodes it: https://github.com/wikimedia/wikipedia-ios-lite/blob/55ba227f2db2a9a815319d032d6129ea75669481/lite/WKUserScripts/InteractionSetupUserScript.swift#L13

• bearND added a comment.Jul 15 2019, 8:01 PM

https://github.com/wikimedia/wikimedia-page-library/pull/218 is merged and will be released soon.

• bearND triaged this task as High priority.Jul 15 2019, 8:42 PM
• bearND moved this task from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog-Deprecated board.
• bearND edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.
• bearND moved this task from To Do to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
Stashbot added a comment.Jul 15 2019, 8:44 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-15T20:44:28Z] <bsitzmann@deploy1001> Started deploy [mobileapps/deploy@bc3a2fd]: Update mobileapps to 7fd39da (T227907)

Stashbot added a comment.Jul 15 2019, 8:52 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-15T20:52:21Z] <bsitzmann@deploy1001> Finished deploy [mobileapps/deploy@bc3a2fd]: Update mobileapps to 7fd39da (T227907) (duration: 07m 53s)

Stashbot added a comment.Jul 15 2019, 8:52 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-15T20:52:28Z] <bsitzmann@deploy1001> Started deploy [mobileapps/deploy@bc3a2fd]: Update mobileapps to 7fd39da (T227907)

• bearND added a comment.Jul 15 2019, 8:54 PM

The deploy keeps failing due to the talk page endpoint timing out.

Check 'endpoints' failed: /{domain}/v1/page/talk/{title} (Get structured talk page for enwiki Salt article) timed out before a response was received
Stashbot added a comment.Jul 15 2019, 8:54 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-15T20:54:49Z] <bsitzmann@deploy1001> Finished deploy [mobileapps/deploy@bc3a2fd]: Update mobileapps to 7fd39da (T227907) (duration: 02m 24s)

Stashbot added a comment.Jul 16 2019, 5:19 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-16T17:19:03Z] <bsitzmann@deploy1001> Started deploy [mobileapps/deploy@cb6e7bc]: Update mobileapps to 334a4c4 (T227907)

Stashbot added a comment.Jul 16 2019, 5:23 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-16T17:23:54Z] <bsitzmann@deploy1001> Finished deploy [mobileapps/deploy@cb6e7bc]: Update mobileapps to 334a4c4 (T227907) (duration: 04m 51s)

• bearND moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jul 16 2019, 5:25 PM
• bearND added a comment.Jul 16 2019, 5:27 PM

MCS deployed with new pagelib release 8.3.0 and
purged:

• bearND closed this task as Resolved.Jul 16 2019, 8:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL