Page MenuHomePhabricator

Enable usergroup "flood" at ptwiki
Closed, ResolvedPublic

Description

The community at ptwiki has reached a consensus for the implementation of the group, which can be added by sysops and bureaucrats.

Thanks in advance!

Event Timeline

Tulsi_Bhagat triaged this task as Medium priority.
Tulsi_Bhagat moved this task from Backlog to Config - to process on the Wikimedia-Site-requests board.
DannyS712 added subscribers: Tulsi_Bhagat, DannyS712.

To confirm google translate's interpretation:

  • User group has 1 right, bot
  • Group can be added by admins and crats
  • Group can be removed by admins, crats, and the user themselves

@Tulsi_Bhagat sorry, edit conflict - if you want to do this just reclaim it

No problem. You can proceed. Thank you!

@Guilhermebm can you confirm this understanding?

@DannyS712 I'll need to confirm the part about the user themselves being able to remove it. Since it's the normal behavior in other wikis, I think that's the way to go, but I'll ask. Thanks!

@DannyS712 yes, the community have confirmed the group can also be removed, but only removed by the user themselves. Thanks!

@DannyS712 sorry. The group can be added by sysops+crats, and removed by sysops, crats and the user themselves. Thanks!

Change 524574 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[operations/mediawiki-config@master] Add flood group to ptwiki

https://gerrit.wikimedia.org/r/524574

Looks redundant. Do you have bureaucrats which are not also sysops? It'd save a line of config.

Looks redundant. Do you have bureaucrats which are not also sysops? It'd save a line of config.

And yet enwiki had an RfC (https://en.wikipedia.org/wiki/Wikipedia:Requests_for_comment/Make_userrights_self-sufficient#Add_move-related_privileges_to_Bureaucrat) that resulted in crats getting explicitly assigned rights that admins already have, and looking through the InitialiseSettings file I see, just at first glance, the following wikis explicitly (in addition to the defaults) allow both admins and crats to add:

  • arwiki - reviewer and abusefilter
  • enwikinews -flood
  • enwikivoyage -patroller
  • eswiki - rollbacker
  • enwikisource - autopatrolled
  • foundationwiki - inactive
  • frwiki - rollbacker

and so on. While I understand your point, I think that it should either be applied globally (eg on wikis where crats can add +sysop, they don't need rights specified explicitly that are already included in that group) or left to communities to decide.

@MarcoAurelio yes, we do have crats which are not sysops. Diego Queiroz is the only one, currently, but in the past there were more. Best regards!

@DannyS712 thanks for the patch!

Change 524574 merged by jenkins-bot:
[operations/mediawiki-config@master] Add flood group to ptwiki

https://gerrit.wikimedia.org/r/524574

Mentioned in SAL (#wikimedia-operations) [2019-07-22T23:42:19Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: Add flood group to ptwiki (T228521) (duration: 00m 47s)

Hi. Looks like the flag is not working. I just assigned it to an user and some edits are still showing up at the Recent Changes.

Information about user: User holds sysop + crat flag. Edits were done with Fastbuttons.

@DannyS712 Should I open another task or this one will do?

I just tested with my own account and it seems to be working fine. Could that be related with something specific that was used by that account (Tuga1143)? Or a script like Fastbuttons?

I just tested with my own account and it seems to be working fine. Could that be related with something specific that was used by that account (Tuga1143)? Or a script like Fastbuttons?

A script that makes edits through the API needs to opt into having the edit marked as "bot", via the "bot=1" parameter. If that parameter is not passed, the interface doesn't mark it as an edit made by bot. That's there so bots can control whether an edit should (not) be considered as automated, as there are some bots that need to be showed at the RC/watchlist.

TLDR: The script needs to pass bot=1 parameter to the API.

I just tested with my own account and it seems to be working fine. Could that be related with something specific that was used by that account (Tuga1143)? Or a script like Fastbuttons?

A script that makes edits through the API needs to opt into having the edit marked as "bot", via the "bot=1" parameter. If that parameter is not passed, the interface doesn't mark it as an edit made by bot. That's there so bots can control whether an edit should (not) be considered as automated, as there are some bots that need to be showed at the RC/watchlist.

TLDR: The script needs to pass bot=1 parameter to the API.

I see. Thanks for explaining. I will bring that to pt.wiki and see what we can do.