Page MenuHomePhabricator

[Bug] Watchlist has skewed thumbnails
Closed, ResolvedPublicBUG REPORT


Steps to reproduce

  1. Login and add Barack Obama to your watchlist.
  2. Visit on the MinervaNeue mobile site.

Expected results

  • Images are scaled proportionally.

Actual results

  • Images are forced to 1:1 square ratios:

en.m.wikipedia.beta.wmflabs.org_wiki_Special_EditWatchlist.png (1×1 px, 239 KB)

Environments observed

  • Browser version: Chromium v75.0.3770.90
  • OS version: Ubuntu v19.04
  • Device model: Desktop
  • Device language: English

Developer notes

Watchlist outputs

<img class="list-thumb list-thumb-x" src="">

rather than

<div class="list-thumb
      " data-style="background-image: url( )" style="background-image: url( )"></div>

and uses some custom CSS.
IT would be good to use the latter and get rid of the additional code needed to support watchlist

It looks like the fix here would be simple - to make sure we pass useBackgroundImage=true to MobilePage->getPageImageHtml in MobileFrontend.

Event Timeline

Change 527202 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Don't skew Watchlist thumbnails

Change 527202 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Don't skew Watchlist thumbnails