Page MenuHomePhabricator

[patch] SQLite install does not check database existence
Closed, ResolvedPublic

Description

check db file existence in mw installer.

When installing MediaWiki@57115 with SQLite support, the installer does not check if the database file exist.

The attached patch:

  • check the file exist before checking its writable status
  • correct a minor typo when writing the 'ok' status.

Version: 1.16.x
Severity: minor

Attached:

Details

Reference
bz20911

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 10:55 PM
bzimport added a project: MediaWiki-Installer.
bzimport set Reference to bz20911.
bzimport added a subscriber: Unknown Object (MLST).
hashar created this task.Sep 30 2009, 6:26 PM

Hmm, why should it need to create the DB first? As SQLite is stateless and permissionless, it doesn't need any special procedure for database setup. It makes sense to keep the current behaviour that creates the database file transparently if it doesn't exist yet, just like MySQL installer creates the needed database on its own.

hashar added a comment.Oct 2 2009, 7:10 PM

With r57115 on Mac OSX, it did not create the database. That's why I added a warning message, it is better than the "Wiki has a problem" page.

I will have a look at the root issue.

Still trying to track the issue. I am kind of new to Mac OS, so that's a bit hard to track for me.

Fixed in r57959