Page MenuHomePhabricator

python files under modules/openstack/files/mitaka/admin_scripts fail pep8
Closed, ResolvedPublic

Description

A number of the Python files under puppet repo's modules/openstack/files/mitaka/admin_scripts fail the pep8/flake8 lint check.

Reverting I65d8cc5 and running tox -e pep8 from the root of the puppet repo will reproduce the failures.

./modules/openstack/files/mitaka/admin_scripts/wmcs-region-migrate.py:118:101: E501 line too long (102 > 100 characters)
./modules/openstack/files/mitaka/admin_scripts/wmcs-region-migrate.py:540:101: E501 line too long (105 > 100 characters)
./modules/openstack/files/mitaka/admin_scripts/wmcs-makedomain.py:18:1: F401 'time' imported but unused
./modules/openstack/files/mitaka/admin_scripts/wmcs-live-migrate.py:113:101: E501 line too long (103 > 100 characters)
./modules/openstack/files/mitaka/admin_scripts/wmcs-cold-nova-migrate.py:88:101: E501 line too long (103 > 100 characters)
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:28:1: F401 'sqlalchemy.delete' imported but unused
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:39:1: E303 too many blank lines (3)
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:64:13: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:66:5: E125 continuation line with same indent as next logical line
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:76:9: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:100:16: E712 comparison to True should be 'if cond is True:' or 'if cond:'
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:101:101: E501 line too long (125 > 100 characters)
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:106:13: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:109:13: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:112:13: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:117:37: W291 trailing whitespace
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:119:13: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:120:17: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:121:17: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:125:17: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:126:17: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:129:13: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:130:13: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:131:21: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:136:9: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:154:17: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:155:17: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:159:17: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:195:13: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:206:31: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:207:31: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:208:31: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:209:31: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:210:31: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:211:31: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:212:31: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:213:31: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:219:101: E501 line too long (128 > 100 characters)
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:226:17: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:237:35: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:238:35: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:239:35: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:240:35: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:241:35: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:242:35: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:243:35: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:244:35: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:253:13: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:254:13: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:266:13: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:267:13: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:269:13: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:280:21: E251 unexpected spaces around keyword / parameter equals
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:292:13: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:293:13: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:313:21: E231 missing whitespace after ','
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:314:19: E231 missing whitespace after ','
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:321:12: E111 indentation is not a multiple of four
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:323:12: E111 indentation is not a multiple of four
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:327:12: E111 indentation is not a multiple of four
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:330:101: E501 line too long (101 > 100 characters)
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:352:9: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:353:9: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:355:9: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:356:9: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:358:9: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:359:9: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:361:9: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:362:9: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:364:9: E128 continuation line under-indented for visual indent
./modules/openstack/files/mitaka/admin_scripts/wmcs-nova-quota-sync/wmcs-nova-quota-sync.py:365:9: E128 continuation line under-indented for visual indent
ERROR: InvocationError for command '/home/cdanis/work/gits/puppet/.tox/pep8/bin/flake8' (exited with code 1)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2019, 8:39 PM
CDanis renamed this task from python files under to python files under modules/openstack/files/mitaka/admin_scripts fail pep8.Jul 29 2019, 8:39 PM

Change 526243 had a related patch set uploaded (by CDanis; owner: CDanis):
[operations/puppet@production] pep8: ignore failing openstack files

https://gerrit.wikimedia.org/r/526243

Change 526256 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[operations/puppet@production] openstack: Fix flake8 warnings in admin_scripts

https://gerrit.wikimedia.org/r/526256

Change 526243 abandoned by CDanis:
pep8: ignore failing openstack files

Reason:
superceded by I1a73ff864

https://gerrit.wikimedia.org/r/526243

Change 526256 merged by Andrew Bogott:
[operations/puppet@production] openstack: Fix flake8 warnings in admin_scripts

https://gerrit.wikimedia.org/r/526256

aborrero closed this task as Resolved.Jul 30 2019, 9:24 AM
aborrero assigned this task to bd808.
aborrero triaged this task as Normal priority.