Following the discussion at this morning's retro, we resolved to try to clean up and perhaps simplify the openstack puppet system we have in place.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T220020 Action items and work for retro 20190403 | |||
| Open | None | T227211 Action items and work for retro 20190703 | |||
| Resolved | aborrero | T220051 Puppet cleanup around OpenStack | |||
| Resolved | bd808 | T229274 python files under modules/openstack/files/mitaka/admin_scripts fail pep8 |
Event Timeline
Comment Actions
I'm unassigning myself because I'm not quite sure what this means :)
The deployment-specific profiles in the openstack setup are a mess, but otherwise I think I'm not all that dissatisfied with our puppet code. Chase rewrote all of them not very long ago, so I'm skeptical that another rewrite would help much. I'm open to airing of specific grievances though!
Comment Actions
Quick summary without further research:
- The first one, which is biting us from time to time is the clientpackages stuff. The problem there is that is used by every VM and also HW servers, so a refactor there should be done with extra care. I already tried (and reverted) a couple of times :-P I will try again soon.
- the second one is hiera inconsistencies. Deployment-specific profiles using :profile::openstack:::base:: hiera keys, etc The physical path in the puppet tree in which they live (usually hieradata/*/profile/*) also caused some issues in the past.
- lack of guidelines or rules. We (mostly me) constantly introduce inconsistencies because we don't have clear rules on how to do certain things. Small and quick example of this are stuff like templates living in modules/openstack/templates/$openstack/$component vs puppet classes living in modules/openstack/manifests/$component/$openstack The difference in the hierarchy is inconsistent and leads to [human] errors.
- there are several files and templates namespaced to a concrete openstack version (modules/{templates,files}/mitaka/*), but they probably don't require this. Bootstrapping another openstack release means duplicating a lot of LOCs.
- we can't reimage some server roles in a single/double puppet agent run. This has probably improved recently, but last time I checked we required like 3 or 4 puppet agents runs before puppet could set up everything. Several missing relationships, etc.
The puppet code is working, but given how important the code is, I believe we should address all these issues (even if they are small).
Comment Actions
Change 506135 had a related patch set uploaded (by Arturo Borrero Gonzalez; owner: Arturo Borrero Gonzalez):
[operations/puppet@production] openstack: clientpackages: split profile for VM instances
Comment Actions
Change 506135 merged by Arturo Borrero Gonzalez:
[operations/puppet@production] openstack: clientpackages: split profile for VM instances
Comment Actions
Change 506146 had a related patch set uploaded (by Arturo Borrero Gonzalez; owner: Arturo Borrero Gonzalez):
[operations/puppet@production] openstack: clientpackages: vms: fix assert for realm
Comment Actions
Mentioned in SAL (#wikimedia-cloud) [2019-04-24T12:54:29Z] <arturo> T220051 puppet broken in every VM in Cloud VPS, fixing right now
Comment Actions
Change 506146 merged by Arturo Borrero Gonzalez:
[operations/puppet@production] openstack: clientpackages: vms: fix assert for realm
Comment Actions
Change 506952 had a related patch set uploaded (by Arturo Borrero Gonzalez; owner: Arturo Borrero Gonzalez):
[operations/puppet@production] openstack: clientpackages: decouple configuration
Comment Actions
Change 506952 merged by Arturo Borrero Gonzalez:
[operations/puppet@production] openstack: clientpackages: decouple configuration
Comment Actions
Change 514445 had a related patch set uploaded (by Arturo Borrero Gonzalez; owner: Arturo Borrero Gonzalez):
[operations/puppet@production] openstack: remove unused common class
Comment Actions
Change 514445 merged by Arturo Borrero Gonzalez:
[operations/puppet@production] openstack: remove unused common class
Comment Actions
Change 530332 had a related patch set uploaded (by Arturo Borrero Gonzalez; owner: Arturo Borrero Gonzalez):
[operations/puppet@production] openstack: cleanup nova-network version of nova
Comment Actions
Change 530332 merged by Arturo Borrero Gonzalez:
[operations/puppet@production] openstack: cleanup nova-network version of nova