The current understanding is that roundtrip-test.js script should work as is against Parsoid/PHP since it simply posts to an API endpoint. We need to test and verify that this is the case.
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | ssastry | T229015 Tracking: Direct live production traffic at Parsoid/PHP | |||
Resolved | Goal | ssastry | T229356 Run roundtrip tests with Parsoid/PHP on scandium | ||
Resolved | Arlolra | T229348 Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint |
Event Timeline
Alright , that's good!
How do we pass in the rt testing flag to Parsoid? Metrics and logging? Linting, etc.
So, overall, I would feel better if we resolved this task (by testing this locally and confirming that everything works. Feel free to retitle and update description to capture actual work involved.
How do we pass in the rt testing flag to Parsoid?
rtTestMode is a property of the SiteConfig.
There's some discussion about that in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/525341
Metrics and logging? Linting, etc.
We haven't got those working yet, have we? But in any case, those would presumably also be part of the SiteConfig.
Since it's up to Parsoid's caller to pass the SiteConfig, how and where that configuration takes place is outside its purview. In this case, the MediaWiki extension probably gets its conf from LocalSettings.php
All the roundtrip test script really wants is a --parsoidURL
Change 527654 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Update docs about using the core rest api
A quick test with, node bin/roundtrip-test.js --domain ve --parsoidURL http://localhost/rest.php "Main Page", is returning,
'data-parsoid': { headers: { 'content-type': 'application/json; charset=utf-8; profile="https://www.mediawiki.org/wiki/Specs/data-parsoid/2.1.0"' }, body: null } }
{\"message\":\"Invalid data-parsoid was provided.\",\"httpCode\":400,\"httpReason\":\"Bad Request\"}
So data-parsoid is staying inline in the response ... probably an indication that $env->pageBundle isn't true
Change 527654 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Update docs about using the core rest api
Change 527843 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Add some support for "pageBundle" to the entrypoint
Change 527843 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Add some support for "pageBundle" to the entrypoint
Change 528218 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Match php storeInPageBundle with js
Change 528218 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Match php storeInPageBundle with js
Change 528248 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Enable selser in the php extension for the time being
Change 528248 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Enable selser in the php extension for the time being
Change 532717 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Resolve port-fix in DOMDataUtils
Change 532717 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Resolve semver PORT-FIXME in DOMDataUtils