Page MenuHomePhabricator

old_content_model and new_content_model aren't set when examinating RC entries
Open, Needs TriagePublic

Description

As I wrote in T230093#5408119:

we need a way to retrieve the content model from a recentchanges row. This is definitely possible, but at a quick glance I'm seeing a long path from rc_this_oldid/rc_last_oldid, then maybe Revision::newFromId but that could fail for deleted stuff, and we can't use Revision::getContentModel because of MCR. Or maybe, from rc_this_oldid go to revision.rev_id, then we cannot use rev_content_model so we'd need to join with the slots table, then with content.content_id and then get content.content_model, which is too long to be true.

Event Timeline

Daimona created this task.Aug 11 2019, 2:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2019, 2:35 PM

Change 529605 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Remove outdated comment, add a new one

https://gerrit.wikimedia.org/r/529605

Change 529605 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Remove outdated comment, add a new one

https://gerrit.wikimedia.org/r/529605

Was about to report this.
To reproduce, visit https://en.wikipedia.org/wiki/Special:AbuseFilter/test?wpFilterRules=true and examine an entry