old_content_model and new_content_model aren't set when examinating RC entries
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Aug 11 2019, 2:35 PM

Description

As I wrote in T230093#5408119:

we need a way to retrieve the content model from a recentchanges row. This is definitely possible, but at a quick glance I'm seeing a long path from rc_this_oldid/rc_last_oldid, then maybe Revision::newFromId but that could fail for deleted stuff, and we can't use Revision::getContentModel because of MCR. Or maybe, from rc_this_oldid go to revision.rev_id, then we cannot use rev_content_model so we'd need to join with the slots table, then with content.content_id and then get content.content_model, which is too long to be true.

Details

	Subject	Repo	Branch	Lines +/-
	Set old_content_model & new_content_model for past changes	mediawiki/extensions/AbuseFilter	master	+30 -2
	Remove outdated comment, add a new one	mediawiki/extensions/AbuseFilter	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T230093: Expose content model to abuse filters
Mentioned Here: T230093: Expose content model to abuse filters

Event Timeline

Daimona created this task.Aug 11 2019, 2:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2019, 2:35 PM

Change 529605 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Remove outdated comment, add a new one

https://gerrit.wikimedia.org/r/529605

gerritbot added a project: Patch-For-Review.Aug 11 2019, 2:35 PM

Daimona mentioned this in T230093: Expose content model to abuse filters.Aug 11 2019, 2:36 PM

Change 529605 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Remove outdated comment, add a new one

https://gerrit.wikimedia.org/r/529605

Maintenance_bot removed a project: Patch-For-Review.Aug 12 2019, 9:10 AM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 20 2019, 5:01 PM

Was about to report this.
To reproduce, visit https://en.wikipedia.org/wiki/Special:AbuseFilter/test?wpFilterRules=true and examine an entry

Change 719242 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/AbuseFilter@master] Set old_content_model & new_content_model for past changes

https://gerrit.wikimedia.org/r/719242

gerritbot added a project: Patch-For-Review.Sep 26 2021, 4:54 PM

matej_suchanek claimed this task.Sep 27 2021, 8:10 AM

matej_suchanek changed the task status from Open to In Progress.Dec 3 2021, 9:01 AM

matej_suchanek triaged this task as Medium priority.

Change 719242 merged by jenkins-bot: