Page MenuHomePhabricator
Create Task
Maniphest T231965

AbuseFilter tests fail on REL1_33: CannotCreateActorException: Cannot create an actor for a usable name that is not an existing user
Closed, ResolvedPublic
Actions

Description

On a dummy REL1_33 change to AbuseFilter ( https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/517645/ ) there are tests failures throwing CannotCreateActorException. Sounds related to T188327: Deploy refactored actor storage

INFO:quibble.commands:PHPUnit extensions suite (with database)
tests/phpunit/phpunit.php --debug-tests --testsuite extensions --group Database
...

There were 6 errors:
1) AbuseFilterConsequencesTest::testFilterConsequences with data set "Basic test for "createaccount", no consequences." (array(1, 2, 3, 4), array('createaccount', 'User:AnotherUser', 'AnotherUser'), array())
=== Logs generated by test case
[wfDebug] [debug] User: loading options for user 2 from database. {"private":false}
[GlobalTitleFail] [info] RequestContext::getTitle called by Hooks::callHook/WikimediaEventsHooks::onUserSaveOptions/WikimediaEventsHooks::isKnownSettingsPage/ContextSource->getTitle/RequestContext->getTitle with no title set. {"private":false}
[wfDebug] [debug] User::getBlockedStatus: checking... {"private":false}
[wfDebug] [debug] IP: 127.0.0.1 {"private":false}
[wfDebug] [debug] IP: 127.0.0.1 {"private":false}
===
CannotCreateActorException: Cannot create an actor for a usable name that is not an existing user

/workspace/src/includes/user/User.php:2516
/workspace/src/includes/ActorMigration.php:220
/workspace/src/includes/logging/LogEntry.php:718
/workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:400
/workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:601
/workspace/src/tests/phpunit/MediaWikiTestCase.php:427
/workspace/src/maintenance/doMaintenance.php:96
2) AbuseFilterConsequencesTest::testFilterConsequences with data set "Basic test for "createaccount", disallowed." (array(15), array('createaccount', 'User:AnotherUser', 'AnotherUser'), array(array(15)))
=== Logs generated by test case
[wfDebug] [debug] User: loading options for user 2 from database. {"private":false}
[GlobalTitleFail] [info] RequestContext::getTitle called by Hooks::callHook/WikimediaEventsHooks::onUserSaveOptions/WikimediaEventsHooks::isKnownSettingsPage/ContextSource->getTitle/RequestContext->getTitle with no title set. {"private":false}
[wfDebug] [debug] User::getBlockedStatus: checking... {"private":false}
[wfDebug] [debug] IP: 127.0.0.1 {"private":false}
[wfDebug] [debug] IP: 127.0.0.1 {"private":false}
===
CannotCreateActorException: Cannot create an actor for a usable name that is not an existing user

/workspace/src/includes/user/User.php:2516
/workspace/src/includes/ActorMigration.php:220
/workspace/src/includes/logging/LogEntry.php:718
/workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:400
/workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:601
/workspace/src/tests/phpunit/MediaWikiTestCase.php:427
/workspace/src/maintenance/doMaintenance.php:96
3) AbuseFilterConsequencesTest::testCondsLimit with data set #7 (array(15), array('createaccount', 'User:AnotherUser', 'AnotherUser'))
=== Logs generated by test case
[wfDebug] [debug] User: loading options for user 2 from database. {"private":false}
[GlobalTitleFail] [info] RequestContext::getTitle called by Hooks::callHook/WikimediaEventsHooks::onUserSaveOptions/WikimediaEventsHooks::isKnownSettingsPage/ContextSource->getTitle/RequestContext->getTitle with no title set. {"private":false}
[wfDebug] [debug] User::getBlockedStatus: checking... {"private":false}
[wfDebug] [debug] IP: 127.0.0.1 {"private":false}
[wfDebug] [debug] IP: 127.0.0.1 {"private":false}
[AbuseFilter] [warning] AbuseFilter parser error for filter 15: Condition limit reached. []
===
CannotCreateActorException: Cannot create an actor for a usable name that is not an existing user

/workspace/src/includes/user/User.php:2516
/workspace/src/includes/ActorMigration.php:220
/workspace/src/includes/logging/LogEntry.php:718
/workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:400
/workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:809
/workspace/src/tests/phpunit/MediaWikiTestCase.php:427
/workspace/src/maintenance/doMaintenance.php:96
4) AbuseFilterConsequencesTest::testTimeLimit with data set #7 (array(15), array('createaccount', 'User:AnotherUser', 'AnotherUser'))
=== Logs generated by test case
[wfDebug] [debug] User: loading options for user 2 from database. {"private":false}
[GlobalTitleFail] [info] RequestContext::getTitle called by Hooks::callHook/WikimediaEventsHooks::onUserSaveOptions/WikimediaEventsHooks::isKnownSettingsPage/ContextSource->getTitle/RequestContext->getTitle with no title set. {"private":false}
[wfDebug] [debug] User::getBlockedStatus: checking... {"private":false}
[wfDebug] [debug] IP: 127.0.0.1 {"private":false}
[wfDebug] [debug] IP: 127.0.0.1 {"private":false}
===
CannotCreateActorException: Cannot create an actor for a usable name that is not an existing user

/workspace/src/includes/user/User.php:2516
/workspace/src/includes/ActorMigration.php:220
/workspace/src/includes/logging/LogEntry.php:718
/workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:400
/workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:837
/workspace/src/tests/phpunit/MediaWikiTestCase.php:427
/workspace/src/maintenance/doMaintenance.php:96
5) AbuseFilterConsequencesTest::testThrottleLimit with data set #5 (array(15), array('createaccount', 'User:AnotherUser', 'AnotherUser'))
=== Logs generated by test case
[wfDebug] [debug] User: loading options for user 2 from database. {"private":false}
[GlobalTitleFail] [info] RequestContext::getTitle called by Hooks::callHook/WikimediaEventsHooks::onUserSaveOptions/WikimediaEventsHooks::isKnownSettingsPage/ContextSource->getTitle/RequestContext->getTitle with no title set. {"private":false}
[wfDebug] [debug] User::getBlockedStatus: checking... {"private":false}
[wfDebug] [debug] IP: 127.0.0.1 {"private":false}
[wfDebug] [debug] IP: 127.0.0.1 {"private":false}
===
CannotCreateActorException: Cannot create an actor for a usable name that is not an existing user

/workspace/src/includes/user/User.php:2516
/workspace/src/includes/ActorMigration.php:220
/workspace/src/includes/logging/LogEntry.php:718
/workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:400
/workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:947
/workspace/src/tests/phpunit/MediaWikiTestCase.php:427
/workspace/src/maintenance/doMaintenance.php:96
6) AbuseFilterConsequencesTest::testThrottle with data set "Basic test for throttling "createaccount"" (array(11), array(array('createaccount', 'User:AnotherUser', 'AnotherUser'), array('createaccount', 'User:YetAnotherUser', 'YetAnotherUser')), array(array(11)))
=== Logs generated by test case
[wfDebug] [debug] User: loading options for user 2 from database. {"private":false}
[GlobalTitleFail] [info] RequestContext::getTitle called by Hooks::callHook/WikimediaEventsHooks::onUserSaveOptions/WikimediaEventsHooks::isKnownSettingsPage/ContextSource->getTitle/RequestContext->getTitle with no title set. {"private":false}
[wfDebug] [debug] User::getBlockedStatus: checking... {"private":false}
[wfDebug] [debug] IP: 127.0.0.1 {"private":false}
[wfDebug] [debug] IP: 127.0.0.1 {"private":false}
[AbuseFilter] [debug] Got value 0 for throttle key wikidb-unittest_:abusefilter:throttle:11:site:356a192b7913b04c54574d18c28d46e6395428ab []
[AbuseFilter] [debug] Added throttle key wikidb-unittest_:abusefilter:throttle:11:site:356a192b7913b04c54574d18c28d46e6395428ab with value 1 []
[AbuseFilter] [debug] Throttle wikidb-unittest_:abusefilter:throttle:11:site:356a192b7913b04c54574d18c28d46e6395428ab not hit! []
===
CannotCreateActorException: Cannot create an actor for a usable name that is not an existing user

/workspace/src/includes/user/User.php:2516
/workspace/src/includes/ActorMigration.php:220
/workspace/src/includes/logging/LogEntry.php:718
/workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:400
/workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:421
/workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:1062
/workspace/src/tests/phpunit/MediaWikiTestCase.php:427
/workspace/src/maintenance/doMaintenance.php:96

Details

SubjectRepoBranchLines +/-
Actually create user in AbuseFilterConsequencesTestmediawiki/extensions/AbuseFilterREL1_33+4 -2
Customize query in gerrit

Related Objects

Event Timeline

hashar created this task.Sep 4 2019, 6:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2019, 6:59 AM
gerritbot added a comment.Sep 4 2019, 7:43 AM

Change 534293 had a related patch set uploaded (by Hashar; owner: Anomie):
[mediawiki/extensions/AbuseFilter@REL1_33] Actually create user in AbuseFilterConsequencesTest

https://gerrit.wikimedia.org/r/534293

gerritbot added a project: Patch-For-Review.Sep 4 2019, 7:43 AM
hashar added a comment.Sep 4 2019, 7:44 AM

The fix is in master ( 5ace1121b0749473dbaec2248bd5f03536f2d41a ) and just needs to be backported ( https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/534293/ ).

gerritbot added a comment.Sep 4 2019, 12:27 PM

Change 534293 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@REL1_33] Actually create user in AbuseFilterConsequencesTest

https://gerrit.wikimedia.org/r/534293

hashar closed this task as Resolved.Sep 4 2019, 12:30 PM
hashar claimed this task.

Fixed by backporting from master via https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/534293/

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2019, 1:10 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL