Page MenuHomePhabricator

Deploy refactored actor storage
Closed, ResolvedPublic

Description

The high-level checklist:

  • 1. Merge the first patch for T167246: Refactor "user" & "user_text" fields into "actor" reference table (adding new schemas and code)
  • 1.1. Check deployed extensions for needed updates.
  • 2. Perform schema change (T188299)
  • Interrupt: Remove read-both (gerrit:461440)
  • 3. Turn the feature flag to "write both, read old". See if stuff breaks.
  • 4. Run the maintenance script(s) to migrate all the old stuff to new stuff.
    • s1
    • s2
    • s3
    • s4
    • s5
    • s6
    • s7
    • s8
    • wikitech
  • 5. Turn the feature flag to "write both, read new". See if stuff breaks.
    • 5.1. Announce the pending change to wikitech-l@ and cloud@, and give time for people to update.
    • 5.2. Make sure all deployed extensions are updated.
    • Beta Cluster
    • Test wikis
    • Group0 wikis
    • Group1 wikis
    • All wikis
  • 6. Turn the feature flag to "new only".
    • Beta Cluster
    • Test wikis
    • Group0 wikis
    • Group1 wikis
    • All wikis
  • 7. Remove old schemas and code
    • 7.1. Update WMCS replicas to no longer reference old schemas (T223406).
    • 7.2. Write and merge patches to remove $wgActorTableSchemaMigrationStage, supporting code, and old schemas (gerrit:525605)
    • 7.3. Submit Schema-change task for WMF production (T233135).

For the cleaning up of revision_actor_temp, see T215466. This and T166733 both block T161671, which in turn is the first step of that task.

Related Objects

StatusAssignedTask
OpenNone
OpenNone
ResolvedAnomie
ResolvedMarostegui
OpenBstorm
OpenAnomie
ResolvedJdforrester-WMF
OpenCiencia_Al_Poder
OpenNone
OpenNone
ResolvedMarostegui
ResolvedAnomie
ResolvedCatrope
ResolvedAnomie
ResolvedAnomie
ResolvedAnomie
ResolvedAnomie
ResolvedAnomie
ResolvedAnomie
ResolvedNiharika
ResolvedMaxSem
ResolvedMusikAnimal
ResolvedBstorm
ResolvedMilimetric
OpenNone

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 502794 had a related patch set uploaded (by Anomie; owner: Anomie):
[operations/mediawiki-config@master] Set ActorTableSchemaMigrationStage => write-both/read-new on group 0

https://gerrit.wikimedia.org/r/502794

Change 502794 merged by jenkins-bot:
[operations/mediawiki-config@master] Set ActorTableSchemaMigrationStage => write-both/read-new on group 0

https://gerrit.wikimedia.org/r/502794

Mentioned in SAL (#wikimedia-operations) [2019-04-10T13:42:33Z] <anomie@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Setting actor migration to write-both/read-new on group0 (T188327) (duration: 01m 00s)

Change 504011 had a related patch set uploaded (by Anomie; owner: Anomie):
[operations/mediawiki-config@master] Set ActorTableSchemaMigrationStage => write-both/read-new on group 1

https://gerrit.wikimedia.org/r/504011

Change 504011 merged by jenkins-bot:
[operations/mediawiki-config@master] Set ActorTableSchemaMigrationStage => write-both/read-new on group 1

https://gerrit.wikimedia.org/r/504011

Change 501595 merged by jenkins-bot:
[mediawiki/core@master] Default $wgActorTableSchemaMigrationStage to SCHEMA_COMPAT_NEW

https://gerrit.wikimedia.org/r/501595

Change 507614 had a related patch set uploaded (by Jforrester; owner: Anomie):
[mediawiki/core@REL1_33] Default $wgActorTableSchemaMigrationStage to READ_NEW

https://gerrit.wikimedia.org/r/507614

Change 507615 had a related patch set uploaded (by Jforrester; owner: Anomie):
[mediawiki/core@REL1_33] Default $wgActorTableSchemaMigrationStage to SCHEMA_COMPAT_NEW

https://gerrit.wikimedia.org/r/507615

Change 507614 merged by jenkins-bot:
[mediawiki/core@REL1_33] Default $wgActorTableSchemaMigrationStage to READ_NEW

https://gerrit.wikimedia.org/r/507614

Change 507615 merged by jenkins-bot:
[mediawiki/core@REL1_33] Default $wgActorTableSchemaMigrationStage to SCHEMA_COMPAT_NEW

https://gerrit.wikimedia.org/r/507615

Change 509844 had a related patch set uploaded (by Anomie; owner: Anomie):
[operations/mediawiki-config@master] Set ActorTableSchemaMigrationStage => write-both/read-new on remaining wikis

https://gerrit.wikimedia.org/r/509844

Change 509844 merged by jenkins-bot:
[operations/mediawiki-config@master] Set ActorTableSchemaMigrationStage => write-both/read-new on remaining wikis

https://gerrit.wikimedia.org/r/509844

Mentioned in SAL (#wikimedia-operations) [2019-05-13T13:36:37Z] <anomie@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Setting actor migration to write-both/read-new on all wikis (T188327) (duration: 00m 50s)

Change 509883 had a related patch set uploaded (by Anomie; owner: Anomie):
[operations/mediawiki-config@master] Set actor migration to write-new on Beta Cluster

https://gerrit.wikimedia.org/r/509883

Change 509883 merged by jenkins-bot:
[operations/mediawiki-config@master] Set actor migration to write-new on Beta Cluster

https://gerrit.wikimedia.org/r/509883

Change 510503 had a related patch set uploaded (by Anomie; owner: Anomie):
[operations/mediawiki-config@master] Set ActorTableSchemaMigrationStage => write-new/read-new on test wikis & mediawikiwiki

https://gerrit.wikimedia.org/r/510503

Change 510503 merged by jenkins-bot:
[operations/mediawiki-config@master] Set ActorTableSchemaMigrationStage => write-new/read-new on test wikis & mediawikiwiki

https://gerrit.wikimedia.org/r/510503

Mentioned in SAL (#wikimedia-operations) [2019-05-15T13:21:15Z] <anomie@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Setting actor migration to write-new/read-new on testwikis and mediawikiwiki (T188327) (duration: 00m 57s)

Anomie updated the task description. (Show Details)
Anomie updated the task description. (Show Details)May 15 2019, 6:55 PM

Change 511444 had a related patch set uploaded (by Anomie; owner: Anomie):
[operations/mediawiki-config@master] Set ActorTableSchemaMigrationStage => write-new/read-new on group 0

https://gerrit.wikimedia.org/r/511444

Change 511444 merged by jenkins-bot:
[operations/mediawiki-config@master] Set ActorTableSchemaMigrationStage => write-new/read-new on group 0

https://gerrit.wikimedia.org/r/511444

Mentioned in SAL (#wikimedia-operations) [2019-05-20T15:13:08Z] <anomie@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Setting actor migration to write-new/read-new on group 0 (T188327) (duration: 00m 55s)

Anomie updated the task description. (Show Details)

Change 513139 had a related patch set uploaded (by Anomie; owner: Anomie):
[operations/mediawiki-config@master] Set ActorTableSchemaMigrationStage => write-new/read-new on group 1

https://gerrit.wikimedia.org/r/513139

Change 513139 merged by jenkins-bot:
[operations/mediawiki-config@master] Set ActorTableSchemaMigrationStage => write-new/read-new on group 1

https://gerrit.wikimedia.org/r/513139

Mentioned in SAL (#wikimedia-operations) [2019-05-29T15:06:12Z] <anomie@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Setting actor migration to write-new/read-new on group 1 (T188327) (duration: 00m 57s)

Anomie updated the task description. (Show Details)May 29 2019, 3:23 PM

Change 513996 had a related patch set uploaded (by Anomie; owner: Anomie):
[operations/mediawiki-config@master] Set ActorTableSchemaMigrationStage => write-new/read-new on remaining wikis

https://gerrit.wikimedia.org/r/513996

Change 513996 merged by jenkins-bot:
[operations/mediawiki-config@master] Set ActorTableSchemaMigrationStage => write-new/read-new on remaining wikis

https://gerrit.wikimedia.org/r/513996

Anomie updated the task description. (Show Details)

Mentioned in SAL (#wikimedia-operations) [2019-06-03T12:55:58Z] <anomie@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Setting actor migration to write-new/read-new on remaining wikis (T188327) (duration: 00m 48s)

Anomie updated the task description. (Show Details)Jun 4 2019, 6:56 PM
WDoranWMF triaged this task as High priority.Jul 23 2019, 3:54 PM

Change 525602 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/extensions/ORES@master] Update for removal of $wgActorTableSchemaMigrationStage

https://gerrit.wikimedia.org/r/525602

Change 525603 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/extensions/UserMerge@master] Update for removal of $wgActorTableSchemaMigrationStage

https://gerrit.wikimedia.org/r/525603

Change 525604 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/extensions/WikimediaMaintenance@master] Update for removal of $wgActorTableSchemaMigrationStage and $wgCommentTableSchemaMigrationStage

https://gerrit.wikimedia.org/r/525604

Change 525605 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Mostly drop old pre-actor user schemas

https://gerrit.wikimedia.org/r/525605

Change 525602 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Update for removal of $wgActorTableSchemaMigrationStage

https://gerrit.wikimedia.org/r/525602

Change 525603 merged by jenkins-bot:
[mediawiki/extensions/UserMerge@master] Update for removal of $wgActorTableSchemaMigrationStage

https://gerrit.wikimedia.org/r/525603

Change 525604 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@master] Update for removal of $wgActorTableSchemaMigrationStage and $wgCommentTableSchemaMigrationStage

https://gerrit.wikimedia.org/r/525604

Change 528952 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Revert actor changes to populateLogSearch.php

https://gerrit.wikimedia.org/r/528952

Change 528952 merged by jenkins-bot:
[mediawiki/core@master] Revert actor changes to populateLogSearch.php

https://gerrit.wikimedia.org/r/528952

Change 534293 had a related patch set uploaded (by Hashar; owner: Anomie):
[mediawiki/extensions/AbuseFilter@REL1_33] Actually create user in AbuseFilterConsequencesTest

https://gerrit.wikimedia.org/r/534293

Change 534293 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@REL1_33] Actually create user in AbuseFilterConsequencesTest

https://gerrit.wikimedia.org/r/534293

Change 525605 merged by jenkins-bot:
[mediawiki/core@master] Mostly drop old pre-actor user schemas

https://gerrit.wikimedia.org/r/525605

Anomie updated the task description. (Show Details)
Anomie closed this task as Resolved.Tue, Sep 17, 5:40 PM
Anomie updated the task description. (Show Details)

Note the final Wikimedia production schema changes are tracked in T233135: Schema change for refactored actor and comment storage, and cleanup of revision_actor_temp in T215466: Remove revision_comment_temp and revision_actor_temp. Changes for any extensions should be tracked in their own tasks.