Page MenuHomePhabricator
Create Task
Maniphest T215525

log_search rows with ls_field='target_author_actor' and empty ls_value are created during actor migration
Closed, ResolvedPublic
Actions

Description

When the actor migration stage is set to write-both and migrateActors.php hasn't been run yet, using RevDel will create entries in log_search with ls_field='target_author_actor' and empty ls_value.

This happened on Wikimedia wikis, and so needs to be cleaned up, but should not be happening anymore since migrateActors.php has already been completed.

  • Patch MediaWiki so this won't happen anymore.
  • Fix the maintenance script's inefficient query.
  • Run maintenance to clean up existing instances of this problem on Wikimedia wikis.

This blocks setting actor migration on Wikimedia wikis to write-both/read-new.

Details

SubjectRepoBranchLines +/-
MigrateActors: Improve query for log_search rowsmediawiki/corewmf/1.33.0-wmf.23+1 -1
MigrateActors: Improve query for log_search rowsmediawiki/corewmf/1.33.0-wmf.24+1 -1
MigrateActors: Improve query for log_search rowsmediawiki/coremaster+1 -1
RevDel: Avoid log_search rows with empty values for target_author_actormediawiki/coremaster+107 -23
Customize query in gerrit

Related Objects
Search...

Event Timeline

Anomie created this task.Feb 7 2019, 4:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2019, 4:11 PM
gerritbot subscribed.Feb 7 2019, 4:38 PM

Change 488961 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] RevDel: Avoid log_search rows with empty values for target_author_actor

https://gerrit.wikimedia.org/r/488961

gerritbot added a project: Patch-For-Review.Feb 7 2019, 4:38 PM
Anomie mentioned this in T188327: Deploy refactored actor storage.Mar 15 2019, 4:43 PM
Nirmos subscribed.Mar 16 2019, 1:24 AM
Anomie mentioned this in T203913: User.php: Cannot create a user with no name, no ID, and no actor ID (Unable to delete certain pages on Chinese Wikisource).Mar 19 2019, 6:07 PM
gerritbot added a comment.Mar 21 2019, 8:42 PM

Change 488961 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] RevDel: Avoid log_search rows with empty values for target_author_actor

https://gerrit.wikimedia.org/r/488961

gerritbot added a comment.Mar 21 2019, 10:03 PM

Change 488961 merged by jenkins-bot:
[mediawiki/core@master] RevDel: Avoid log_search rows with empty values for target_author_actor

https://gerrit.wikimedia.org/r/488961

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.23; 2019-03-26).Mar 21 2019, 11:01 PM
daniel subscribed.Apr 1 2019, 11:38 AM

Looks like the patch is merged. Now this needs a maintenance script to run, right?

daniel moved this task from Waiting for Review to Ready on the Platform Team Workboards board.Apr 1 2019, 11:38 AM
daniel edited projects, added Platform Team Workboards; removed Platform Team Workboards (Waiting for Review).
daniel triaged this task as Medium priority.Apr 1 2019, 1:26 PM
Stashbot added a comment.Apr 2 2019, 1:44 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-02T13:44:27Z] <anomie@mwmaint1002> Fixing empty values for 'target_author_actor' in log_search on test wikis and mediawikiwiki for T215525

Anomie updated the task description. (Show Details)Apr 2 2019, 1:45 PM
Anomie edited projects, added Platform Team Workboards (Waiting for Review); removed Platform Team Workboards.Apr 2 2019, 2:43 PM

When running the maintenance script on mediawikiwiki, I found that a query can no longer use the indexes properly after the change made for T216247: DatabaseMysql(Base)::buildStringCast should probably actually cast. In brief, the join ON ( ls_value = CAST( actor_user AS BINARY ) ) can't use the actor_user index as intended. It needs to cast the other way instead, ON ( actor_user = CAST( ls_value AS INTEGER ) ).

gerritbot added a comment.Apr 2 2019, 2:43 PM

Change 500754 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] MigrateActors: Improve query for log_search rows

https://gerrit.wikimedia.org/r/500754

Anomie updated the task description. (Show Details)Apr 2 2019, 2:43 PM
gerritbot added a comment.Apr 3 2019, 8:27 AM

Change 500754 merged by jenkins-bot:
[mediawiki/core@master] MigrateActors: Improve query for log_search rows

https://gerrit.wikimedia.org/r/500754

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.25; 2019-04-09); removed MW-1.33-notes (1.33.0-wmf.23; 2019-03-26).Apr 3 2019, 9:01 AM
gerritbot added a comment.Apr 3 2019, 2:27 PM

Change 500969 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@wmf/1.33.0-wmf.23] MigrateActors: Improve query for log_search rows

https://gerrit.wikimedia.org/r/500969

gerritbot added a comment.Apr 3 2019, 2:27 PM

Change 500970 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@wmf/1.33.0-wmf.24] MigrateActors: Improve query for log_search rows

https://gerrit.wikimedia.org/r/500970

Anomie edited projects, added Platform Team Workboards (Doing); removed Platform Team Workboards (Waiting for Review), Patch-For-Review.Apr 3 2019, 2:31 PM
Anomie updated the task description. (Show Details)
gerritbot added a comment.Apr 3 2019, 2:53 PM

Change 500969 merged by jenkins-bot:
[mediawiki/core@wmf/1.33.0-wmf.23] MigrateActors: Improve query for log_search rows

https://gerrit.wikimedia.org/r/500969

gerritbot added a comment.Apr 3 2019, 2:53 PM

Change 500970 merged by jenkins-bot:
[mediawiki/core@wmf/1.33.0-wmf.24] MigrateActors: Improve query for log_search rows

https://gerrit.wikimedia.org/r/500970

Stashbot added a comment.Apr 3 2019, 2:59 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-03T14:59:33Z] <anomie@mwmaint1002> Fixing empty values for 'target_author_actor' in log_search on section 1 wikis for T215525

Stashbot added a comment.Apr 3 2019, 3:00 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-03T15:00:06Z] <anomie@mwmaint1002> Fixing empty values for 'target_author_actor' in log_search on section 2 wikis for T215525

Stashbot added a comment.Apr 3 2019, 3:00 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-03T15:00:09Z] <anomie@mwmaint1002> Fixing empty values for 'target_author_actor' in log_search on remaining section 3 wikis for T215525

Stashbot added a comment.Apr 3 2019, 3:00 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-03T15:00:12Z] <anomie@mwmaint1002> Fixing empty values for 'target_author_actor' in log_search on section 4 wikis for T215525

Stashbot added a comment.Apr 3 2019, 3:00 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-03T15:00:15Z] <anomie@mwmaint1002> Fixing empty values for 'target_author_actor' in log_search on section 5 wikis for T215525

Stashbot added a comment.Apr 3 2019, 3:00 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-03T15:00:18Z] <anomie@mwmaint1002> Fixing empty values for 'target_author_actor' in log_search on section 6 wikis for T215525

Stashbot added a comment.Apr 3 2019, 3:00 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-03T15:00:21Z] <anomie@mwmaint1002> Fixing empty values for 'target_author_actor' in log_search on section 7 wikis for T215525

Stashbot added a comment.Apr 3 2019, 3:00 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-03T15:00:24Z] <anomie@mwmaint1002> Fixing empty values for 'target_author_actor' in log_search on section 8 wikis for T215525

Stashbot added a comment.Apr 3 2019, 3:00 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-03T15:00:29Z] <anomie@mwmaint1002> Fixing empty values for 'target_author_actor' in log_search on wikitech for T215525

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.23; 2019-03-26); removed MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 3 2019, 3:01 PM
Anomie closed this task as Resolved.Apr 3 2019, 4:16 PM
Anomie updated the task description. (Show Details)

Script run and results checked.

WDoranWMF edited projects, added Platform Team Workboards (Done with CPT); removed Platform Team Workboards (Doing).Jul 5 2019, 3:26 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits