Page MenuHomePhabricator

Support query parameters in Special:EntityPage
Closed, ResolvedPublic

Description

As a developer, I want to write browser tests without knowing the repo’s configuration, in order to ensure software quality.
As a Wikibase user, I want to link to entities on another repository without knowing that repository’s entity namespaces.

Problem:
Special:EntityPage exists to redirect requests to the correct namespace for an entity (e. g. Special:EntityPage/Q1 may redirect to Q1 or Item:Q1). However, it discards any query parameters, so you can’t use it e. g. to link to a specific revision, or to an entity’s history.

Example:

  • Special:EntityPage/Q6?revision=123 Special:EntityPage/Q6?oldid=123
  • Special:EntityPage/Q6?action=history

Acceptance criteria:

  • The revision oldid parameter is passed through.
  • The action parameter is passed through.

Open questions:

  • Which other parameters should be passed through? undo/undoafter/restore?

Event Timeline

Change 535893 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Support query parameters in Special:EntityPage

https://gerrit.wikimedia.org/r/535893

Unassigning myself, I think I’ve done all I can for now.

Change 535893 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Support query parameters in Special:EntityPage

https://gerrit.wikimedia.org/r/535893

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

The revision parameter is passed through.

Scratch this. Wiki pages don’t support a revision parameter, it’s called oldid.

Change 683912 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Fix allowed Special:EntityPage parameter

https://gerrit.wikimedia.org/r/683912

Change 683912 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix allowed Special:EntityPage parameter

https://gerrit.wikimedia.org/r/683912