Page MenuHomePhabricator
Create Task
Maniphest T220826

Wikibase Special:EntityData has 2 parameters that do the same thing
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Currently Special:EntityData has 2 different ways to request a specific revision.

https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/repo/includes/LinkedData/EntityDataRequestHandler.php#L200-L201

"revision" and "oldid"
revision is used far more than oldid T220826#5182044 & T220826#5185202

I propose that we either entirely remove one, or redirect requests that use one to use the other.

The motivations behind this change would be:

  • remove the redundancy / confusions of looking at requests that have different parameters that do the same thing
  • Allow for more cache hits (currently is revision=1 is used and then oldid=1 is used, this results in an unneeded varnish miss)

Details

SubjectRepoBranchLines +/-
Drop redundant "oldid" argument from Special:EntityDatamediawiki/extensions/Wikibasemaster+0 -1
Customize query in gerrit

Related Objects

Event Timeline

Addshore created this task.Apr 12 2019, 2:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 12 2019, 2:04 PM
Addshore triaged this task as Low priority.Apr 12 2019, 2:04 PM
Lydia_Pintscher added subscribers: WMDE-leszek, • alaa_wmde, Lydia_Pintscher.Apr 14 2019, 4:21 PM

I don't think we want to remove one completely as there are probably enough uses out there. If we can redirect one to the other that seems fine from my side though.

Lydia_Pintscher added a project: Wikidata-Campsite.Apr 14 2019, 4:21 PM

@WMDE-leszek @alaa_wmde can you help me get this ready for pickup?

Lydia_Pintscher moved this task from Incoming to Needs Work on the Wikidata-Campsite board.Apr 14 2019, 4:22 PM
Addshore added a comment.EditedMay 14 2019, 5:29 PM

I took a look at the usage on a current day:

revision	10710135
none	7665964
oldid	2

So oldid is barely used, and revisions is used lots.
Thus revision is probably the main one we should use / keep

Generated with P8524

Addshore updated the task description. (Show Details)May 14 2019, 5:30 PM
WMDE-leszek added a comment.May 15 2019, 7:15 AM

@Addshore that sounds like an easy choice then. Would you say it makes sense to see number for some past month or so, to be 100% sure it was not some kind of one-day anomaly? On one hand, the difference seems so huge that I could see that it is not necessary, OTOH it is this huge difference which makes me think about an anomaly in the first place. To be clear, I don't have a strong preference on doing further analysis topic.

Looking at the query in P8524, do I interpret it right that oldid use is only counted when the revision parameter is not used? Do we care about cases when both revision and oldid are part of the input?

Addshore added a comment.May 15 2019, 5:12 PM
In T220826#5183700, @WMDE-leszek wrote:

Looking at the query in P8524, do I interpret it right that oldid use is only counted when the revision parameter is not used? Do we care about cases when both revision and oldid are part of the input?

Correct

I altered the query to take that into account and ran it for the whole of this month so far.
P8531

revisionparamoldidparamrequests
00170005141
10149359378
012

Not an anomaly, infact, the fact that I even managed to find the 2 requests that used the oldid param is quite amazing, heh...

Addshore updated the task description. (Show Details)May 15 2019, 5:13 PM
WMDE-leszek added a comment.May 16 2019, 11:14 AM

Thank you sir. So yes, it does look like oldid could go. And probably should, as what's the point of the additional complexity and source of errors, if it is not intended to be used?

Addshore added a comment.Jul 8 2019, 7:20 PM

Indeed, let's get rid of oldid :)

Addshore moved this task from Needs Work to Ready to estimate on the Wikidata-Campsite board.Jul 8 2019, 7:20 PM
Addshore moved this task from incoming to consider for next sprint on the Wikidata board.
• alaa_wmde set the point value for this task to 3.Jul 9 2019, 12:12 PM
• alaa_wmde moved this task from Ready to estimate to Ready to pick up on the Wikidata-Campsite board.

We decided to remove the legacy redundant oldid. following the usual BC announcement process

gerritbot added a comment.Jul 16 2019, 6:43 PM

Change 523790 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Drop redundant oldid from Special:EntityData

https://gerrit.wikimedia.org/r/523790

gerritbot added a project: Patch-For-Review.Jul 16 2019, 6:43 PM
Ladsgroup claimed this task.Jul 16 2019, 6:48 PM
Ladsgroup edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJul 16 2019, 6:48 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 16 2019, 6:48 PM
hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 17 2019, 10:27 PM
gerritbot added a comment.Jul 17 2019, 10:50 PM

Change 523790 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Drop redundant "oldid" argument from Special:EntityData

https://gerrit.wikimedia.org/r/523790

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.15; 2019-07-23).Jul 17 2019, 11:00 PM
• alaa_wmde closed this task as Resolved.Jul 29 2019, 11:43 AM
• alaa_wmde moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

verified in production

Lucas_Werkmeister_WMDE subscribed.Sep 18 2019, 11:06 AM

documentation updated

Lucas_Werkmeister_WMDE mentioned this in T240223: Step 1: Ensure that Wikidata Bridge uses fresh entity data (impact: high).Dec 11 2019, 11:55 AM
Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.Dec 11 2019, 12:15 PM
Maintenance_bot moved this task from In progress to Done on the User-Ladsgroup board.
Lucas_Werkmeister_WMDE mentioned this in T98035: [Task] Drop support for php-serialized output from Special:EntityData.Feb 18 2020, 6:01 PM
Lucas_Werkmeister_WMDE mentioned this in T232629: Support query parameters in Special:EntityPage.Mar 9 2020, 12:54 PM
Lucas_Werkmeister_WMDE mentioned this in T40971: API: Access old versions of entities.Jun 3 2020, 12:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL