Page MenuHomePhabricator
Create Task
Maniphest T23302

Send squid purges for extensions and specifically, on curid urls on DynamicPageList
Open, LowPublic
Actions

Description

SquidUpdate, Title, DynamicPageList

This code aims to fix bug 20818 squid caching issues.

First, SquidUpdate::newFromTitles() is changed to be based on getSquidURLs() instead of generating the url by itself. This probably fixes caching problems on wikis with variants.

Second, TitleSquidURLs hook is added to allow extensions to add extra article-related urls which need purging.

Third, DynamicPageList is modified to use the new hook to purge the ?curid urls it generates.

Version: 1.16.x
Severity: normal

attachment bug 21032.patch ignored as obsolete

Details

Reference
bz21302

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 10:55 PM
• bzimport added a project: MediaWiki-Parser.
• bzimport set Reference to bz21302.
• bzimport added a subscriber: Unknown Object (MLST).
Platonides created this task.Oct 26 2009, 3:21 PM
siebrand added a comment.Jan 9 2010, 6:49 PM

Can you please revise the patch, as bug 20818 has been resolved? (or do i have the relations the wrong way around?)

Platonides added a comment.Jan 9 2010, 7:05 PM

Bug 20818 was fixed by not using curids for Google.

In strict sense, curid urls should always be purged.
Here it was just doing it when DPL is active, to decrease load.
If DPL is handling out curid links, those shouldn't lead to old pages.

Perhaps there should be a DPL option to choose if allowing curid urls or not?

Bawolff added a comment.Jan 10 2010, 5:44 AM

Note: There is no longer any need for DPL's to output curid's whatsoever. The only reason it was there in the first place was to have a number in the urls. Since that can just as easily be served as a dummy parameter (which it is currently), DPL really does not need this anymore.

Platonides added a comment.Jan 10 2010, 10:39 AM

Right, but we may want (or not) to still fix caching problem with curid urls.
And there is also the issue of variant wikis.

• bzimport added a comment.Jan 10 2012, 10:33 PM

sumanah wrote:

Platonides, marking your patch as obsolete since it doesn't apply cleanly to trunk anymore. I'm cc'ing Gabriel Wicke in case he wants to consider this issue and your approach in the parser rewrite.

• bzimport added a comment.Jan 10 2012, 10:34 PM

sumanah wrote:

Comment on attachment 6722
SquidUpdate, Title, DynamicPageList

This patch no longer applies to trunk per Rusty Burchfield's automated testing
https://docs.google.com/spreadsheet/ccc?key=0Ah_71HHl7qa7dGtvSms3TGpHQU9NU2Y1VmNzUEUteWc .

Bawolff added a comment.Jan 10 2012, 10:42 PM

(In reply to comment #5)

Platonides, marking your patch as obsolete since it doesn't apply cleanly to
trunk anymore. I'm cc'ing Gabriel Wicke in case he wants to consider this
issue and your approach in the parser rewrite.

This isn't really a parser issue.

Meno25 unsubscribed.Nov 23 2018, 7:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits