Page MenuHomePhabricator

Regression: popup videos (kaltura player) don't play on first attempt with Safari 13
Closed, ResolvedPublic

Description

Looks like something regressed in the initialization of the audio context when using the popup video handler on Safari 13.0 (just released today).

On a page like https://commons.wikimedia.org/wiki/Main_Page scroll down to the media of the day and click the play button -- it will pop up a video player dialog and should start playback, but does not.

Close the video and try again and it will work.

Video players shown directly such as on File: pages or with video.js mode are not affected.

Event Timeline

brion created this task.Sep 19 2019, 8:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2019, 8:23 PM
brion updated the task description. (Show Details)Sep 19 2019, 8:26 PM
brion added a comment.Sep 19 2019, 8:52 PM

Looks like the audio wasn't getting initialized at the right time (how did it work on iOS? no clue!) unless mwEmbedSupport has already been loaded.

I'll have to the ext.tmh.OgvJsSupport module as a dep on mw.PopUpThumbVideo and call it there, I think.

Change 538110 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@master] Fix Safari 13.0 regression in video playback with audio

https://gerrit.wikimedia.org/r/538110

Change 538110 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Fix Safari 13.0 regression in video playback with audio

https://gerrit.wikimedia.org/r/538110

Change 538130 had a related patch set uploaded (by Jforrester; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.23] Fix Safari 13.0 regression in video playback with audio

https://gerrit.wikimedia.org/r/538130

Change 538130 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.23] Fix Safari 13.0 regression in video playback with audio

https://gerrit.wikimedia.org/r/538130

Mentioned in SAL (#wikimedia-operations) [2019-09-20T01:05:08Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.23/extensions/TimedMediaHandler/: T233360 Fix Safari 13.0 regression in video playback with audio (duration: 00m 58s)