Page MenuHomePhabricator
Create Task
Maniphest T233449

CommentStore should accept valid combinations of SCHEMA_COMPAT_* constants
Closed, ResolvedPublic
Actions

Description

It currently accepts the subset that are used for the MIGRATION_* constants. But extensions doing actor and comment migrations at the same time, such as CheckUser, will most likely want to use the progression used for actor migration rather than the MIGRATION_* constants.

Details

SubjectRepoBranchLines +/-
CommentStore: Accept SCHEMA_COMPAT_* constantsmediawiki/coremaster+235 -35
Customize query in gerrit

Event Timeline

Anomie created this task.Sep 20 2019, 6:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 20 2019, 6:49 PM
gerritbot added a comment.Sep 20 2019, 6:51 PM

Change 538317 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] CommentStore: Accept SCHEMA_COMPAT_* constants

https://gerrit.wikimedia.org/r/538317

gerritbot added a project: Patch-For-Review.Sep 20 2019, 6:51 PM
Anomie moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Sep 20 2019, 6:51 PM
• mobrovac moved this task from Waiting for Review to Waiting for deployment on the Platform Team Workboards (Clinic Duty Team) board.Sep 26 2019, 11:42 AM
gerritbot added a comment.Sep 26 2019, 12:17 PM

Change 538317 merged by jenkins-bot:
[mediawiki/core@master] CommentStore: Accept SCHEMA_COMPAT_* constants

https://gerrit.wikimedia.org/r/538317

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).Sep 26 2019, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 26 2019, 1:10 PM
Anomie closed this task as Resolved.Sep 26 2019, 2:56 PM
WDoranWMF moved this task from Waiting for deployment to Done on the Platform Team Workboards (Clinic Duty Team) board.Oct 29 2019, 3:27 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL