Page MenuHomePhabricator

GWToolset needs 'editToken' replaced with 'csrfToken'
Closed, ResolvedPublic

Description

GWToolset needs 'editToken' replaced with 'csrfToken' in a resources/js/ext.gwtoolset.js file.

Event Timeline

Restricted Application added a project: Commons. · View Herald TranscriptSep 22 2019, 3:45 PM

Change 538428 had a related patch set uploaded (by TheSandDoctor; owner: TheSandDoctor):
[mediawiki/extensions/GWToolset@master] GWToolset: Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/538428


I am clearly on a separate branch, yet in git's infinite wisdom it decides now to make the commit on master. I am thoroughly confused. Will have to redo my vagrant again I guess so that I get new .git folders.


I am clearly on a separate branch, yet in git's infinite wisdom it decides now to make the commit on master. I am thoroughly confused. Will have to redo my vagrant again I guess so that I get new .git folders.

T233527 is your local branch, but git will push patch per default on master as you cloned repository which is in master branch.

In T233527#5513773, @Zoranzoki21 wrote:


I am clearly on a separate branch, yet in git's infinite wisdom it decides now to make the commit on master. I am thoroughly confused. Will have to redo my vagrant again I guess so that I get new .git folders.

T233527 is your local branch, but git will push patch per default on master as you cloned repository which is in master branch.

Apparently I never noticed that somehow......nevermind.

TheSandDoctor triaged this task as Medium priority.Sep 22 2019, 8:27 PM

Change 538428 merged by jenkins-bot:
[mediawiki/extensions/GWToolset@master] GWToolset: Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/538428

TheSandDoctor closed this task as Resolved.Sep 24 2019, 1:10 AM
TheSandDoctor moved this task from git review pending to merged/done on the User-TheSandDoctor board.