Page MenuHomePhabricator
Create Task
Maniphest T233527

GWToolset needs 'editToken' replaced with 'csrfToken'
Closed, ResolvedPublic
Actions

Description

GWToolset needs 'editToken' replaced with 'csrfToken' in a resources/js/ext.gwtoolset.js file.

Details

SubjectRepoBranchLines +/-
GWToolset: Replace deprecated editToken with csrfTokenmediawiki/extensions/GWToolsetmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Kizule created this task.Sep 22 2019, 3:43 PM
Kizule removed a project: Technical-Debt (Deprecation process).
Kizule edited projects, added MediaWiki-extensions-GWToolset; removed MediaWiki-ResourceLoader.Sep 22 2019, 3:45 PM
Restricted Application added a project: Commons. · View Herald TranscriptSep 22 2019, 3:45 PM
Aklapper removed a project: Performance-Team.Sep 22 2019, 3:57 PM
Kizule assigned this task to TheSandDoctor.Sep 22 2019, 4:32 PM
gerritbot added a comment.Sep 22 2019, 5:07 PM

Change 538428 had a related patch set uploaded (by TheSandDoctor; owner: TheSandDoctor):
[mediawiki/extensions/GWToolset@master] GWToolset: Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/538428

gerritbot added a project: Patch-For-Review.Sep 22 2019, 5:07 PM
TheSandDoctor added a comment.Sep 22 2019, 5:11 PM

wrong_branch.PNG (314×977 px, 25 KB)

I am clearly on a separate branch, yet in git's infinite wisdom it decides now to make the commit on master. I am thoroughly confused. Will have to redo my vagrant again I guess so that I get new .git folders.

Kizule added a comment.Sep 22 2019, 5:17 PM
In T233527#5513767, @TheSandDoctor wrote:

wrong_branch.PNG (314×977 px, 25 KB)

I am clearly on a separate branch, yet in git's infinite wisdom it decides now to make the commit on master. I am thoroughly confused. Will have to redo my vagrant again I guess so that I get new .git folders.

T233527 is your local branch, but git will push patch per default on master as you cloned repository which is in master branch.

TheSandDoctor added a comment.Sep 22 2019, 5:18 PM
In T233527#5513773, @Zoranzoki21 wrote:
In T233527#5513767, @TheSandDoctor wrote:

wrong_branch.PNG (314×977 px, 25 KB)

I am clearly on a separate branch, yet in git's infinite wisdom it decides now to make the commit on master. I am thoroughly confused. Will have to redo my vagrant again I guess so that I get new .git folders.

T233527 is your local branch, but git will push patch per default on master as you cloned repository which is in master branch.

Apparently I never noticed that somehow......nevermind.

TheSandDoctor triaged this task as Medium priority.Sep 22 2019, 8:27 PM
TheSandDoctor added a project: User-TheSandDoctor.Sep 23 2019, 6:46 AM
TheSandDoctor moved this task from Backlog to git review pending on the User-TheSandDoctor board.
gerritbot added a comment.Sep 24 2019, 1:09 AM

Change 538428 merged by jenkins-bot:
[mediawiki/extensions/GWToolset@master] GWToolset: Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/538428

TheSandDoctor closed this task as Resolved.Sep 24 2019, 1:10 AM
TheSandDoctor moved this task from git review pending to merged/done on the User-TheSandDoctor board.
Maintenance_bot removed a project: Patch-For-Review.Sep 24 2019, 1:10 AM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).Sep 24 2019, 2:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL