Page MenuHomePhabricator

Eventlogging is not compatible with python3?
Closed, DuplicatePublic

Description

I see tasks like T164409: EventLogging tests fail for python 3.4 in Jenkins, so it was surprising to discover that the scripts under bin are python2-only. Since we have 3 months before python2 is end-of-lifed, I'm raising this as an issue.

The first glitch I encountered is that many of the scripts rely on reload. There is a python 3 equivalent, but the code is doing something weird and no comment was provided, so I'd first question whether we need this workaround at all:

import sys
reload(sys)  # noqa

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Thanks a lot for the task :)

We started collecting python2 -> python 3 use cases in https://phabricator.wikimedia.org/T204734, and there is a subtask about eventlogging: T233231

Up to now we concentrated our efforts in two fronts:

  1. removed/deprecated eventbus from our infrastructure (so avoid porting it to python3 as well, since it Eventbus has been historically placed in the same repository as eventlogging and shared some code).
  2. started moving other tools to python3 only (Refinery, Report Updater, etc..

We are aware of the python2 deprecation deadline, next quarter will have a goal to move everything to Python3. If you want to participate/contribute please do so, you are more than welcome!

We started collecting python2 -> python 3 use cases in https://phabricator.wikimedia.org/T204734, and there is a subtask about eventlogging: T233231

Hi, thanks for the duplicate link, closing this task now!