html2wt: TypeError in ConstrainedText.php
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ssastry
	Sep 25 2019, 1:46 PM

Description

Found just a single instance of this error in rt testing.

Exception msg:

Argument 1 passed to Parsoid\Html2Wt\ConstrainedText\ConstrainedText::fromSelSer() must be of the type string, boolean given, called in /srv/deployment/parsoid/deploy/src/src/Html2Wt/ConstrainedText/ConstrainedText.php on line 292

Exception url:

/w/rest.php/ar.wikipedia.org/v3/transform/pagebundle/to/wikitext/%D8%B1%D8%A7%D9%85%D8%B2%20%D8%AC%D9%84%D8%A7%D9%84/38325396

Exception trace:

#0 /srv/deployment/parsoid/deploy/src/src/Html2Wt/ConstrainedText/ConstrainedText.php(292): Parsoid\Html2Wt\ConstrainedText\ConstrainedText::fromSelSer(boolean, DOMElement, stdClass, Parsoid\Config\Env, array)
#1 [internal function]: Parsoid\Html2Wt\ConstrainedText\ConstrainedText::fromSelSerImpl(string, DOMElement, stdClass, Parsoid\Config\Env, array)
#2 /srv/deployment/parsoid/deploy/src/src/Html2Wt/ConstrainedText/ConstrainedText.php(208): call_user_func(array, string, DOMElement, stdClass, Parsoid\Config\Env, array)
#3 /srv/deployment/parsoid/deploy/src/src/Html2Wt/WikitextSerializer.php(1233): Parsoid\Html2Wt\ConstrainedText\ConstrainedText::fromSelSer(string, DOMElement, stdClass, Parsoid\Config\Env)
#4 [internal function]: Parsoid\Html2Wt\WikitextSerializer->serializeDOMNode(DOMElement, Parsoid\Html2Wt\DOMHandlers\ListHandler)
#5 /srv/deployment/parsoid/deploy/src/src/Html2Wt/WikitextSerializer.php(1373): call_user_func(array, DOMElement, Parsoid\Html2Wt\DOMHandlers\ListHandler)
#6 /srv/deployment/parsoid/deploy/src/src/Html2Wt/SerializerState.php(667): Parsoid\Html2Wt\WikitextSerializer->serializeNode(DOMElement)
#7 /srv/deployment/parsoid/deploy/src/src/Html2Wt/SerializerState.php(690): Parsoid\Html2Wt\SerializerState->serializeChildren(DOMElement, NULL)
#8 /srv/deployment/parsoid/deploy/src/src/Html2Wt/WikitextSerializer.php(1646): Parsoid\Html2Wt\SerializerState->kickOffSerialize(DOMElement)
#9 /srv/deployment/parsoid/deploy/src/src/Html2Wt/SelectiveSerializer.php(117): Parsoid\Html2Wt\WikitextSerializer->serializeDOM(DOMElement, boolean)
#10 /srv/deployment/parsoid/deploy/src/src/WikitextContentModelHandler.php(100): Parsoid\Html2Wt\SelectiveSerializer->serializeDOM(DOMElement)
#11 /srv/deployment/parsoid/deploy/src/src/Parsoid.php(149): Parsoid\WikitextContentModelHandler->fromHTML(Parsoid\Config\Env, DOMDocument, Parsoid\SelserData)
#12 /srv/deployment/parsoid/deploy/src/extension/src/Rest/Handler/ParsoidHandler.php(692): Parsoid\Parsoid->html2wikitext(MWParsoid\Config\PageConfig, Parsoid\PageBundle, array, Parsoid\SelserData)
#13 /srv/deployment/parsoid/deploy/src/extension/src/Rest/Handler/TransformHandler.php(78): MWParsoid\Rest\Handler\ParsoidHandler->html2wt(Parsoid\Config\Env, array, string)
#14 /srv/mediawiki/php-1.34.0-wmf.23/includes/Rest/Router.php(307): MWParsoid\Rest\Handler\TransformHandler->execute()
#15 /srv/mediawiki/php-1.34.0-wmf.23/includes/Rest/Router.php(286): MediaWiki\Rest\Router->executeHandler(MWParsoid\Rest\Handler\TransformHandler)
#16 /srv/mediawiki/php-1.34.0-wmf.23/includes/Rest/EntryPoint.php(112): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#17 /srv/mediawiki/php-1.34.0-wmf.23/includes/Rest/EntryPoint.php(79): MediaWiki\Rest\EntryPoint->execute()
#18 /srv/mediawiki/php-1.34.0-wmf.23/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#19 /srv/mediawiki/w/rest.php(3): require(string)
#20 {main}

Details

	Subject	Repo	Branch	Lines +/-
	Bump Parsoid to v0.12.0-a16	mediawiki/vendor	master	+3 K -3 K
	html2wt in selser mode: Don't crash on bad DSR	mediawiki/services/parsoid	master	+78 -18

Customize query in gerrit

Related Objects

Mentioned In: T254412: Bad DSRs on fostered content

Event Timeline

ssastry created this task.Sep 25 2019, 1:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2019, 1:46 PM

ssastry triaged this task as Medium priority.Sep 25 2019, 2:06 PM

ssastry moved this task from Backlog to Bugs, Notices, Crashers on the Parsoid-PHP board.

Arlolra claimed this task.Sep 25 2019, 5:29 PM

			DOMUtils::assertElt( $lastChild ); // implied by $lastChildDp
			$len = $lastChildDp->dsr->length();
			$suffixChunks = self::fromSelSer(
				substr( $text, -$len ), $lastChild, $lastChildDp, $env,
				// this child node's left context will be protected:
				[ 'ignorePrefix' => true ]
			);

The substr method returns false on failure, which seems to be what's happening here. Probably ultimately a bad DSR in $lastChildDp->dsr.

Arlolra removed Arlolra as the assignee of this task.Sep 25 2019, 6:00 PM

Arlolra subscribed.

ssastry merged a task: T244789: Argument 1 passed to Parsoid\Html2Wt\ConstrainedText\ConstrainedText::fromSelSer() must be of the type string, boolean given, called in /srv/deployment/parsoid/deploy-cache/revs/e8610ff26ce18bb39effc30d03d1863aa5cf072f/src/src/Html2Wt/ConstrainedText/ConstrainedText.php on line 292.Feb 11 2020, 10:14 PM

/w/rest.php/es.wikipedia.org/v3/transform/pagebundle/to/wikitext/Esterilizaci%C3%B3n_(microbiolog%C3%ADa)/123778395

Aklapper edited projects, added Parsoid; removed Parsoid-PHP.Apr 10 2020, 4:27 PM

ssastry moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Apr 10 2020, 4:53 PM

ssastry raised the priority of this task from Medium to High.May 13 2020, 8:16 PM

In case an enwiki page makes it easier to debug, here is one from rt testing

ssastry@scandium:/srv/parsoid-testing$ node bin/roundtrip-test.js --proxyURL http://scandium.eqiad.wmnet:80 --parsoidURL http://DOMAIN/w/rest.php --domain en.wikipedia.org "1970 FA Cup Final" --oldid 956878467
Parser failure!

----------------------------------------------------------------------
Error: Got status code: 500; ...

https://en.wikipedia.org/w/index.php?title=User:SSastry_(WMF)/sandbox&oldid=958030712 is the minimal test that reproduces the bug:

{|
*x
*y
|}

On scandium:

ssastry@scandium:/srv/parsoid-testing$ node bin/roundtrip-test.js --proxyURL http://scandium.eqiad.wmnet:80 --parsoidURL http://DOMAIN/w/rest.php --domain en.wikipedia.org "User:SSastry (WMF)/sandbox" --oldid 958030712
Parser failure!

----------------------------------------------------------------------
Error: Got status code: 500;  ...

Change 597889 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] WIP: Don't crash on bad DSR

https://gerrit.wikimedia.org/r/597889

gerritbot added a project: Patch-For-Review.May 21 2020, 11:13 PM

ssastry claimed this task.May 21 2020, 11:15 PM

ssastry added a project: Parsing-Active-Work.

ssastry moved this task from Incoming Work (but not yet ready) to Doing (Other Work) on the Parsing-Active-Work board.

cscott mentioned this in T254412: Bad DSRs on fostered content.Jun 3 2020, 11:01 PM

Change 597889 merged by jenkins-bot:
[mediawiki/services/parsoid@master] html2wt in selser mode: Don't crash on bad DSR

https://gerrit.wikimedia.org/r/597889

Maintenance_bot removed a project: Patch-For-Review.Jun 4 2020, 12:10 AM

ssastry closed this task as Resolved.Jun 4 2020, 12:14 AM

Change 603571 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump Parsoid to v0.12.0-a16

https://gerrit.wikimedia.org/r/603571

gerritbot added a project: Patch-For-Review.Jun 8 2020, 6:50 PM

Change 603571 merged by jenkins-bot:
[mediawiki/vendor@master] Bump Parsoid to v0.12.0-a16