Page MenuHomePhabricator
Create Task
Maniphest T234066

Schema change to rename user_newtalk indexes
Closed, ResolvedPublic
Actions

Description

From the checklist at https://wikitech.wikimedia.org/wiki/Schema_changes:

  1. ALTERs to run: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/537694/4/maintenance/archives/patch-rename-mysql-user_newtalk-indexes.sql
  2. Where to run those changes: all.dblist
  3. When to run those changes: No time constraint.
  4. If the schema change is backwards compatible: Yes. Nothing accesses these indexes by name.
  5. If the schema change has been tested already on some of the test/beta wikis: It appears to have been auto-deployed to Beta. No error reports.
  6. If the data should be made available on the labs replicas and/or dumps: N/A, no new data is being added here.

Progress:

  • labswiki
  • labtestwiki

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Anomie mentioned this in T233240: Remove MySQL aliasing for user_newtalk indexes.Sep 27 2019, 5:03 PM
Marostegui triaged this task as Medium priority.Sep 30 2019, 7:14 AM
Marostegui moved this task from Triage to Pending comment on the DBA board.
Marostegui claimed this task.Oct 3 2019, 6:02 AM
Marostegui moved this task from Pending comment to In progress on the DBA board.
Marostegui updated the task description. (Show Details)Oct 3 2019, 6:15 AM
Stashbot mentioned this in T233135: Schema change for refactored actor and comment storage.Oct 3 2019, 6:16 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-03T06:16:03Z] <marostegui> Deploy schema change on db2089:3316 T233135 T234066

Marostegui added a comment.Oct 3 2019, 7:02 AM

This is how the table looks like in db2089:3316 after the ALTER:

frwiki
*************************** 1. row ***************************
       Table: user_newtalk
Create Table: CREATE TABLE `user_newtalk` (
  `user_id` int(10) unsigned NOT NULL DEFAULT '0',
  `user_ip` varbinary(40) NOT NULL DEFAULT '',
  `user_last_timestamp` varbinary(14) DEFAULT NULL,
  KEY `un_user_id` (`user_id`),
  KEY `un_user_ip` (`user_ip`)
) ENGINE=InnoDB DEFAULT CHARSET=binary ROW_FORMAT=COMPRESSED KEY_BLOCK_SIZE=8
jawiki
*************************** 1. row ***************************
       Table: user_newtalk
Create Table: CREATE TABLE `user_newtalk` (
  `user_id` int(10) unsigned NOT NULL DEFAULT '0',
  `user_ip` varbinary(40) NOT NULL DEFAULT '',
  `user_last_timestamp` varbinary(14) DEFAULT NULL,
  KEY `un_user_id` (`user_id`),
  KEY `un_user_ip` (`user_ip`)
) ENGINE=InnoDB DEFAULT CHARSET=binary ROW_FORMAT=COMPRESSED KEY_BLOCK_SIZE=8
ruwiki
*************************** 1. row ***************************
       Table: user_newtalk
Create Table: CREATE TABLE `user_newtalk` (
  `user_id` int(10) unsigned NOT NULL DEFAULT '0',
  `user_ip` varbinary(40) NOT NULL DEFAULT '',
  `user_last_timestamp` varbinary(14) DEFAULT NULL,
  KEY `un_user_id` (`user_id`),
  KEY `un_user_ip` (`user_ip`)
) ENGINE=InnoDB DEFAULT CHARSET=binary ROW_FORMAT=COMPRESSED KEY_BLOCK_SIZE=8
Marostegui added a comment.EditedOct 3 2019, 7:03 AM

s6:

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1005
  • db2129
  • db2124
  • db2117
  • db2114
  • db2097
  • db2095
  • db2089
  • db2087
  • db2076
  • db1139
  • db1131
  • db1125
  • db1113
  • db1098
  • db1096
  • db1093
  • db1088
  • db1085
  • db1061
Marostegui updated the task description. (Show Details)Oct 3 2019, 7:03 AM
Marostegui updated the task description. (Show Details)Oct 3 2019, 7:39 AM
Stashbot added a comment.Oct 3 2019, 8:26 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-03T08:26:52Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1096:3316 for schema change T233135 T234066', diff saved to https://phabricator.wikimedia.org/P9236 and previous config saved to /var/cache/conftool/dbconfig/20191003-082651-marostegui.json

Stashbot added a comment.Oct 3 2019, 8:33 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-03T08:33:13Z] <marostegui> Deploy schema change on db2087:3316 T233135 T234066

Anomie added a comment.Oct 3 2019, 3:40 PM
In T234066#5543364, @Marostegui wrote:

This is how the table looks like in db2089:3316 after the ALTER:

All three look correct. Thanks!

Stashbot added a comment.Oct 4 2019, 6:16 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-04T06:16:47Z] <marostegui> Deploy schema change on dbstore1005:3316 T233135 T234066

Stashbot added a comment.Oct 4 2019, 6:41 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-04T06:40:59Z] <marostegui> Deploy schema change on db2114 T233135 T234066

Stashbot added a comment.Oct 4 2019, 8:41 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-04T08:41:38Z] <marostegui> Deploy schema change on db2076 (sanitarium master) with replication T233135 T234066

Stashbot added a comment.Oct 4 2019, 12:28 PM

Mentioned in SAL (#wikimedia-operations) [2019-10-04T12:28:29Z] <marostegui> Deploy schema change on db2097:3316 T233135 T234066

Stashbot added a comment.Oct 4 2019, 2:03 PM

Mentioned in SAL (#wikimedia-operations) [2019-10-04T14:03:21Z] <marostegui> Deploy schema change on db2117 T233135 T234066

Stashbot added a comment.Oct 7 2019, 4:54 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-07T04:54:12Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1098:3316 for schema change T233135 T234066', diff saved to https://phabricator.wikimedia.org/P9245 and previous config saved to /var/cache/conftool/dbconfig/20191007-045411-marostegui.json

Stashbot added a comment.Oct 7 2019, 5:25 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-07T05:25:27Z] <marostegui> Deploy schema change on db2124 T233135 T234066

Stashbot added a comment.Oct 7 2019, 9:55 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-07T09:55:01Z] <marostegui> Deploy schema change on db2129 (s6 codfw master), this will generate lag on s6 codfw - T233135 T234066

Stashbot added a comment.Oct 7 2019, 1:17 PM

Mentioned in SAL (#wikimedia-operations) [2019-10-07T13:17:22Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1098:3316 schema change T233135 T234066', diff saved to https://phabricator.wikimedia.org/P9248 and previous config saved to /var/cache/conftool/dbconfig/20191007-131720-marostegui.json

Marostegui updated the task description. (Show Details)Oct 7 2019, 2:12 PM
Stashbot added a comment.Oct 7 2019, 2:17 PM

Mentioned in SAL (#wikimedia-operations) [2019-10-07T14:17:40Z] <marostegui> Deploy schema change on db1139:3316 - T233135 T234066

Ladsgroup subscribed.Oct 7 2019, 4:28 PM
Stashbot added a comment.Oct 10 2019, 4:53 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-10T04:53:54Z] <marostegui> Deploy schema change on db1061 (s6 eqiad master) - T233135 T234066

Marostegui updated the task description. (Show Details)Oct 10 2019, 10:12 AM
Stashbot added a comment.Oct 10 2019, 11:40 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-10T11:40:53Z] <marostegui> Deploy schema change on s7 codfw master (db2118), this will generate lag on s7 codfw - T234066 T233135

Marostegui updated the task description. (Show Details)Oct 11 2019, 4:51 AM
Marostegui added a comment.EditedOct 14 2019, 9:13 AM

s7 eqiad progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1003
  • db1136
  • db1125
  • db1116
  • db1101
  • db1098
  • db1094
  • db1090
  • db1086
  • db1079
  • db1062
Stashbot added a comment.Oct 14 2019, 2:21 PM

Mentioned in SAL (#wikimedia-operations) [2019-10-14T14:21:34Z] <marostegui> Deploy schema change on db1116:3317 T234066 T233135

Stashbot added a comment.Oct 15 2019, 5:28 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-15T05:28:49Z] <marostegui> Deploy schema change on db1098:3317 T234066 T233135

Marostegui moved this task from Backlog to In progress on the Schema-change-in-production board.Oct 15 2019, 7:51 AM
Stashbot added a comment.Oct 16 2019, 5:08 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-16T05:08:05Z] <marostegui> Deploy schema change on s7 sanitarium master (db1079) this will create lag on s7 labsdb T233135 T234066

Marostegui added a comment.EditedOct 16 2019, 5:17 AM

s2 eqiad progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1004
  • db1129
  • db1125
  • db1122
  • db1105
  • db1103
  • db1095
  • db1090
  • db1076
  • db1074
Stashbot added a comment.Oct 16 2019, 5:18 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-16T05:18:28Z] <marostegui> Deploy schema change on s2 sanitarium master (db1074) this will create lag on s2 labsdb T233135 T234066

Marostegui updated the task description. (Show Details)Oct 16 2019, 5:57 AM
Stashbot added a comment.Oct 16 2019, 10:17 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-16T10:17:10Z] <marostegui> Stop replication on s2 codfw master for schema change and to modify sanitarium triggers T234066 T233135 T234704

Stashbot mentioned this in T234704: Remove ar_comment from sanitarium triggers.Oct 16 2019, 10:17 AM
Stashbot added a comment.Oct 16 2019, 3:17 PM

Mentioned in SAL (#wikimedia-operations) [2019-10-16T15:17:27Z] <marostegui> Deploy schema change on dbstore1004:3312 - T234066 T233135

Marostegui updated the task description. (Show Details)Oct 17 2019, 5:02 AM
Marostegui updated the task description. (Show Details)Oct 17 2019, 5:30 AM
Stashbot added a comment.Oct 18 2019, 5:15 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-18T05:15:54Z] <marostegui> Deploy schema change on db1129 T233135 T234066

Stashbot added a comment.Oct 21 2019, 5:09 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-21T05:09:38Z] <marostegui> Deploy schema change on s7 primary master db1062 - T234066 T233135

Stashbot added a comment.Oct 21 2019, 5:14 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-21T05:14:28Z] <marostegui> Deploy schema change on db1090:3312 T234066 T233135

Marostegui updated the task description. (Show Details)Oct 21 2019, 9:25 AM
Stashbot added a comment.Oct 21 2019, 1:04 PM

Mentioned in SAL (#wikimedia-operations) [2019-10-21T13:04:47Z] <marostegui> Deploy schema change on db1122 (s2 primary master) - T233135 T234066

Marostegui updated the task description. (Show Details)Oct 22 2019, 4:57 AM
Stashbot added a comment.Nov 12 2019, 6:40 AM

Mentioned in SAL (#wikimedia-operations) [2019-11-12T06:40:51Z] <marostegui> Deploy schema change on s5 codfw with replication, this will generate lag on s5 codfw T233135 T234066

Marostegui updated the task description. (Show Details)Nov 12 2019, 10:32 AM
Marostegui added a comment.EditedNov 12 2019, 11:35 AM

s5 eqiad progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1003
  • db1130
  • db1124
  • db1113
  • db1110
  • db1102
  • db1100
  • db1097
  • db1096
  • db1082
Stashbot added a comment.Nov 12 2019, 3:41 PM

Mentioned in SAL (#wikimedia-operations) [2019-11-12T15:41:29Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1097:3315 for a schema change T233135 T234066', diff saved to https://phabricator.wikimedia.org/P9600 and previous config saved to /var/cache/conftool/dbconfig/20191112-154127-marostegui.json

Stashbot added a comment.Nov 12 2019, 3:49 PM

Mentioned in SAL (#wikimedia-operations) [2019-11-12T15:49:26Z] <marostegui> Deploy schema change on db1102:3315 T233135 T234066

Marostegui updated the task description. (Show Details)Nov 13 2019, 8:06 AM
Stashbot added a comment.Nov 14 2019, 8:41 AM

Mentioned in SAL (#wikimedia-operations) [2019-11-14T08:41:30Z] <marostegui> Deploy schema change with replication on db1082, this will generate lag on s5 labs - T233135 T234066

Stashbot added a comment.Nov 18 2019, 5:53 AM

Mentioned in SAL (#wikimedia-operations) [2019-11-18T05:53:57Z] <marostegui> Deploy schema change on s5 primary master db1100 - T233135 T234066

Marostegui updated the task description. (Show Details)Nov 18 2019, 9:08 AM
Stashbot added a comment.Nov 18 2019, 9:11 AM

Mentioned in SAL (#wikimedia-operations) [2019-11-18T09:11:12Z] <marostegui> Deploy schema change on s8 codfw, this will generate lag on s8 codfw - T233135 T234066

Marostegui updated the task description. (Show Details)Nov 18 2019, 2:18 PM
Marostegui added a comment.EditedNov 18 2019, 2:23 PM

s8 eqiad progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1005
  • db1126
  • db1124
  • db1116
  • db1109
  • db1104
  • db1101
  • db1099
  • db1092
  • db1087
Marostegui updated the task description. (Show Details)Nov 19 2019, 5:27 AM
Stashbot added a comment.Nov 25 2019, 2:37 PM

Mentioned in SAL (#wikimedia-operations) [2019-11-25T14:37:26Z] <marostegui> Deploy schema change on s1 codfw (this will generate lag on codfw) - T234066 T233135

Marostegui updated the task description. (Show Details)Nov 26 2019, 5:46 AM
Marostegui added a comment.EditedNov 26 2019, 5:50 AM

s1 eqiad progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1003
  • db1139
  • db1134
  • db1124
  • db1119
  • db1114
  • db1118
  • db1106
  • db1105
  • db1099
  • db1089
  • db1083
  • db1080
Stashbot added a comment.Nov 26 2019, 9:26 AM

Mentioned in SAL (#wikimedia-operations) [2019-11-26T09:26:50Z] <marostegui> Deploy schema change on s8 primary master (db1109) - T234066 T233135 T237120

Stashbot mentioned this in T237120: Schema change on production for increase the size of wbt_text_in_lang.wbxl_language.Nov 26 2019, 9:26 AM
Marostegui updated the task description. (Show Details)Nov 27 2019, 6:58 AM
Marostegui updated the task description. (Show Details)Nov 27 2019, 7:44 AM
Stashbot added a comment.Nov 28 2019, 1:37 PM

Mentioned in SAL (#wikimedia-operations) [2019-11-28T13:37:26Z] <marostegui> Deploy schema change on db1106 with replication (lag will appear on s1 on labs) - T234066 T233135

Stashbot added a comment.Nov 28 2019, 1:57 PM

Mentioned in SAL (#wikimedia-operations) [2019-11-28T13:57:08Z] <marostegui> Deploy schema change on s4 codfw master with replication - T234066

Marostegui updated the task description. (Show Details)Nov 28 2019, 1:57 PM
Marostegui added a comment.EditedNov 28 2019, 2:00 PM

s4 eqiad progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1004
  • db1138
  • db1125
  • db1121
  • db1103
  • db1102
  • db1097
  • db1091
  • db1084
  • db1081
Marostegui updated the task description. (Show Details)Nov 28 2019, 2:15 PM
Stashbot added a comment.Nov 28 2019, 2:20 PM

Mentioned in SAL (#wikimedia-operations) [2019-11-28T14:20:18Z] <marostegui> Deploy schema change on s3 codfw on the master, lag will appear on s3 codfw (T234066)

Marostegui updated the task description. (Show Details)EditedNov 28 2019, 2:29 PM

s3 eqiad

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1004
  • db1124
  • db1123
  • db1112
  • db1095
  • db1078
  • db1075
Marostegui updated the task description. (Show Details)Nov 28 2019, 2:57 PM
Marostegui updated the task description. (Show Details)Nov 29 2019, 6:03 AM
Marostegui closed this task as Resolved.Nov 29 2019, 6:06 AM
Marostegui updated the task description. (Show Details)

All done

Ladsgroup mentioned this in T250067: user_newtalk has two indexes not renamed in s4.Apr 13 2020, 11:23 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL