Page MenuHomePhabricator

Schema change to rename user_newtalk indexes
Open, NormalPublic

Description

From the checklist at https://wikitech.wikimedia.org/wiki/Schema_changes:

  1. ALTERs to run: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/537694/4/maintenance/archives/patch-rename-mysql-user_newtalk-indexes.sql
  2. Where to run those changes: all.dblist
  3. When to run those changes: No time constraint.
  4. If the schema change is backwards compatible: Yes. Nothing accesses these indexes by name.
  5. If the schema change has been tested already on some of the test/beta wikis: It appears to have been auto-deployed to Beta. No error reports.
  6. If the data should be made available on the labs replicas and/or dumps: N/A, no new data is being added here.

Progress:

  • s4
    • codfw
    • eqiad
  • s5
    • codfw
    • eqiad
  • s8
    • codfw
    • eqiad
  • labswiki
  • labtestwiki

Event Timeline

Marostegui triaged this task as Normal priority.Mon, Sep 30, 7:14 AM
Marostegui moved this task from Triage to Next on the DBA board.
Marostegui moved this task from Next to In progress on the DBA board.
Marostegui updated the task description. (Show Details)Thu, Oct 3, 6:15 AM

This is how the table looks like in db2089:3316 after the ALTER:

frwiki
*************************** 1. row ***************************
       Table: user_newtalk
Create Table: CREATE TABLE `user_newtalk` (
  `user_id` int(10) unsigned NOT NULL DEFAULT '0',
  `user_ip` varbinary(40) NOT NULL DEFAULT '',
  `user_last_timestamp` varbinary(14) DEFAULT NULL,
  KEY `un_user_id` (`user_id`),
  KEY `un_user_ip` (`user_ip`)
) ENGINE=InnoDB DEFAULT CHARSET=binary ROW_FORMAT=COMPRESSED KEY_BLOCK_SIZE=8
jawiki
*************************** 1. row ***************************
       Table: user_newtalk
Create Table: CREATE TABLE `user_newtalk` (
  `user_id` int(10) unsigned NOT NULL DEFAULT '0',
  `user_ip` varbinary(40) NOT NULL DEFAULT '',
  `user_last_timestamp` varbinary(14) DEFAULT NULL,
  KEY `un_user_id` (`user_id`),
  KEY `un_user_ip` (`user_ip`)
) ENGINE=InnoDB DEFAULT CHARSET=binary ROW_FORMAT=COMPRESSED KEY_BLOCK_SIZE=8
ruwiki
*************************** 1. row ***************************
       Table: user_newtalk
Create Table: CREATE TABLE `user_newtalk` (
  `user_id` int(10) unsigned NOT NULL DEFAULT '0',
  `user_ip` varbinary(40) NOT NULL DEFAULT '',
  `user_last_timestamp` varbinary(14) DEFAULT NULL,
  KEY `un_user_id` (`user_id`),
  KEY `un_user_ip` (`user_ip`)
) ENGINE=InnoDB DEFAULT CHARSET=binary ROW_FORMAT=COMPRESSED KEY_BLOCK_SIZE=8
Marostegui added a comment.EditedThu, Oct 3, 7:03 AM

s6:

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1005
  • db2129
  • db2124
  • db2117
  • db2114
  • db2097
  • db2095
  • db2089
  • db2087
  • db2076
  • db1139
  • db1131
  • db1125
  • db1113
  • db1098
  • db1096
  • db1093
  • db1088
  • db1085
  • db1061
Marostegui updated the task description. (Show Details)Thu, Oct 3, 7:03 AM
Marostegui updated the task description. (Show Details)Thu, Oct 3, 7:39 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-03T08:26:52Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1096:3316 for schema change T233135 T234066', diff saved to https://phabricator.wikimedia.org/P9236 and previous config saved to /var/cache/conftool/dbconfig/20191003-082651-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2019-10-03T08:33:13Z] <marostegui> Deploy schema change on db2087:3316 T233135 T234066

Anomie added a comment.Thu, Oct 3, 3:40 PM

This is how the table looks like in db2089:3316 after the ALTER:

All three look correct. Thanks!

Mentioned in SAL (#wikimedia-operations) [2019-10-04T06:16:47Z] <marostegui> Deploy schema change on dbstore1005:3316 T233135 T234066

Mentioned in SAL (#wikimedia-operations) [2019-10-04T06:40:59Z] <marostegui> Deploy schema change on db2114 T233135 T234066

Mentioned in SAL (#wikimedia-operations) [2019-10-04T08:41:38Z] <marostegui> Deploy schema change on db2076 (sanitarium master) with replication T233135 T234066

Mentioned in SAL (#wikimedia-operations) [2019-10-04T12:28:29Z] <marostegui> Deploy schema change on db2097:3316 T233135 T234066

Mentioned in SAL (#wikimedia-operations) [2019-10-04T14:03:21Z] <marostegui> Deploy schema change on db2117 T233135 T234066

Mentioned in SAL (#wikimedia-operations) [2019-10-07T04:54:12Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1098:3316 for schema change T233135 T234066', diff saved to https://phabricator.wikimedia.org/P9245 and previous config saved to /var/cache/conftool/dbconfig/20191007-045411-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2019-10-07T05:25:27Z] <marostegui> Deploy schema change on db2124 T233135 T234066

Mentioned in SAL (#wikimedia-operations) [2019-10-07T09:55:01Z] <marostegui> Deploy schema change on db2129 (s6 codfw master), this will generate lag on s6 codfw - T233135 T234066

Mentioned in SAL (#wikimedia-operations) [2019-10-07T13:17:22Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1098:3316 schema change T233135 T234066', diff saved to https://phabricator.wikimedia.org/P9248 and previous config saved to /var/cache/conftool/dbconfig/20191007-131720-marostegui.json

Marostegui updated the task description. (Show Details)Mon, Oct 7, 2:12 PM

Mentioned in SAL (#wikimedia-operations) [2019-10-07T14:17:40Z] <marostegui> Deploy schema change on db1139:3316 - T233135 T234066

Mentioned in SAL (#wikimedia-operations) [2019-10-10T04:53:54Z] <marostegui> Deploy schema change on db1061 (s6 eqiad master) - T233135 T234066

Marostegui updated the task description. (Show Details)Thu, Oct 10, 10:12 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-10T11:40:53Z] <marostegui> Deploy schema change on s7 codfw master (db2118), this will generate lag on s7 codfw - T234066 T233135

Marostegui updated the task description. (Show Details)Fri, Oct 11, 4:51 AM
Marostegui added a comment.EditedMon, Oct 14, 9:13 AM

s7 eqiad progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1003
  • db1136
  • db1125
  • db1116
  • db1101
  • db1098
  • db1094
  • db1090
  • db1086
  • db1079
  • db1062

Mentioned in SAL (#wikimedia-operations) [2019-10-14T14:21:34Z] <marostegui> Deploy schema change on db1116:3317 T234066 T233135

Mentioned in SAL (#wikimedia-operations) [2019-10-15T05:28:49Z] <marostegui> Deploy schema change on db1098:3317 T234066 T233135

Mentioned in SAL (#wikimedia-operations) [2019-10-16T05:08:05Z] <marostegui> Deploy schema change on s7 sanitarium master (db1079) this will create lag on s7 labsdb T233135 T234066

Marostegui added a comment.EditedWed, Oct 16, 5:17 AM

s2 eqiad progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1004
  • db1129
  • db1125
  • db1122
  • db1105
  • db1103
  • db1095
  • db1090
  • db1076
  • db1074

Mentioned in SAL (#wikimedia-operations) [2019-10-16T05:18:28Z] <marostegui> Deploy schema change on s2 sanitarium master (db1074) this will create lag on s2 labsdb T233135 T234066

Marostegui updated the task description. (Show Details)Wed, Oct 16, 5:57 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-16T10:17:10Z] <marostegui> Stop replication on s2 codfw master for schema change and to modify sanitarium triggers T234066 T233135 T234704

Mentioned in SAL (#wikimedia-operations) [2019-10-16T15:17:27Z] <marostegui> Deploy schema change on dbstore1004:3312 - T234066 T233135

Marostegui updated the task description. (Show Details)Thu, Oct 17, 5:02 AM
Marostegui updated the task description. (Show Details)Thu, Oct 17, 5:30 AM