Page MenuHomePhabricator

Page issues icon is misaligned vertically
Closed, ResolvedPublic2 Estimated Story Points

Description

The icons in the page-issues treatment are misaligned after the update to mw-ui-icon.

image.png (1×778 px, 240 KB)
image.png (1×788 px, 214 KB)

Developer notes

The use of inline styles in page issues is what causes the problem. The font size of the icon needs to be restricted to the text not the container containing the icon. The line-height for the icon is also different from the text.

At this point a hack hardcoding the top position is probably the best option but should only happen when we've increased the touch area sizes of icons (T230033)

Event Timeline

Aklapper renamed this task from Page issues icon is misaligned verticallyy to Page issues icon is misaligned vertically.Sep 30 2019, 10:06 PM
ovasileva triaged this task as Medium priority.Oct 1 2019, 4:01 PM
ovasileva set the point value for this task to 2.Oct 1 2019, 4:30 PM

Change 541568 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Hardcode page issues vertically alignment

https://gerrit.wikimedia.org/r/541568

Change 541568 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Hardcode page issues vertically alignment

https://gerrit.wikimedia.org/r/541568

ovasileva claimed this task.
ovasileva added a subscriber: ovasileva.

All done!