| Esanders | |
| Aug 7 2019, 3:48 PM |
| F30543933: Screen Shot 2019-10-04 at 1.08.00 PM.png | |
| Oct 4 2019, 5:17 PM |
| F30050874: Screenshot 2019-08-20 at 2.00.04 PM.png | |
| Aug 20 2019, 9:02 PM |
| F30050064: image.png | |
| Aug 20 2019, 1:11 PM |
| F30050062: image.png | |
| Aug 20 2019, 1:09 PM |
| F30008981: image.png | |
| Aug 12 2019, 4:14 PM |
| F30008651: image.png | |
| Aug 12 2019, 3:54 PM |
| F30006895: image.png | |
| Aug 11 2019, 11:45 AM |
| F30006893: image.png | |
| Aug 11 2019, 11:45 AM |
Most mobile guidelines suggest touch targets of at least 44x44dp.
In MF/AMC after changing all icons the click targets are currently 40x40 by accident.
Updating the icon sizes involves updating a variable value. This hopefully shouldn't impact other things, but as with all our other icon changes we've had so far we shouldn't be so confident :)
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ovasileva | T226562 AMC - display labels for toolbar actions on larger screens | |||
| Resolved | • alexhollender_WMF | T229440 [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency | |||
| Resolved | ovasileva | T230033 [ICONS] Increase touch targets from 40x40 to 44x44 |
Change 529595 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/skins/MinervaNeue@master] AMC actions: Increase touch target size to 44px
Change 529595 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] AMC actions: Increase touch target size to 44px
@alexhollender, this change seemed like a nice improvement to me so I merged it. If there are any issues on your end, please let me know.
Change 529811 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Watchstar: Apply rotation to image, not link
Change 529813 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/skins/MinervaNeue@master] Fix touch targets in header
Change 529811 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Watchstar: Apply rotation to image, not link
For completion, that's a success criterion for WCAG 2.1 level AAA.
We should always aim for 44 sp in one direction and 34 sp minimum in the other direction. 44 x 44 sp should be the optimum, but there might be design or technical limitations where it's necessary to break with that optimum.
Change 531186 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/skins/MinervaNeue@master] Fix touch target of section edit buttons
This is the issue with the header I'm seeing on https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/529813/ :
Change 531531 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Fix touch target height of editor close button
Change 531558 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] WIP: Change the default behaviour for mw-ui-icon
@Nirzar, please weigh in on Design's requirements when you can.
Back to @alexhollender.
@alexhollender we'll also need some direction on what the exact preferred touch target size should be with 20px by 20px glyphs.
@Jdlrobson looks like @Volker_E specified the desired touch target sizes, which (if I'm understanding this correctly) don't change even when we reduce the icon size from 24px to 20px:
Change 533111 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove icon hacks
In kick off we agreed to push this to the backlog. We will pull it back in when T229440 is ready to QA
Change 531186 abandoned by Jdlrobson:
Fix touch target of section edit buttons
Reason:
Not needed any more since https://gerrit.wikimedia.org/r/533360 has landed.
After the latest icon fixes, most of these are now 40x40, which is just slightly below the recommended size. Was this a deliberate choice?
Change 531531 abandoned by Jdlrobson:
Fix touch target height of search and editor close buttons
Reason:
Taken care of in https://gerrit.wikimedia.org/r/537165
Change 537165 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] bump icon touch areas to 44x44
Change 529813 abandoned by Jdlrobson:
Fix touch targets in header
Reason:
See https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/ /537165/
@ovasileva this should be in blocked on others. We talked about this during last estimation meeting (wednesday) and said all the other icon patches should be done before we consider bumping the size of the icons
Change 537165 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Bump icon touch areas to 44x44
