Page MenuHomePhabricator

Add debug() PSR messages to cache-related service wiring
Closed, ResolvedPublic

Description

Follows from https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/533701/.

We used to have it for:

  • WAN - service MainWANObjectCache
  • stash - service MainObjectStash
  • message - service MessageCache
  • session - SessionManager::__construct
  • cluster - Hard to add, as it isn't a service. But seems rare enough that it might not matter. Covered by WAN for most if not all wikis. I'll treat this as non-blocking for now, to maybe add in a later release.

Perhaps it would also be useful to add it to:

  • parser - service ParserCache
  • apc-like backend - service LocalServerObjectCache

Event Timeline

Krinkle created this task.Tue, Oct 1, 6:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Oct 1, 6:50 PM
Krinkle added a subscriber: Anomie.EditedTue, Oct 1, 6:51 PM

Tagging as 1.34 because it was removed recently and the fix should be made and backported before public release.

EDIT: Before 1 Nov 2019.

Krinkle claimed this task.Tue, Oct 8, 12:23 AM
Krinkle triaged this task as Low priority.

Change 541646 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] objectcache: Log debug message for backend of WANObjectCache

https://gerrit.wikimedia.org/r/541646

Change 541646 merged by jenkins-bot:
[mediawiki/core@master] objectcache: Log debug message for backend of WANObjectCache

https://gerrit.wikimedia.org/r/541646

Change 542204 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@REL1_34] objectcache: Log debug message for backend of WANObjectCache

https://gerrit.wikimedia.org/r/542204

Change 542204 merged by jenkins-bot:
[mediawiki/core@REL1_34] objectcache: Log debug message for backend of WANObjectCache

https://gerrit.wikimedia.org/r/542204

Change 542221 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] objectcache: Log debug message for backend of MainObjectStash

https://gerrit.wikimedia.org/r/542221

Change 542221 merged by jenkins-bot:
[mediawiki/core@master] objectcache: Log debug message for backend of MainObjectStash

https://gerrit.wikimedia.org/r/542221

Change 542622 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@REL1_34] objectcache: Log debug message for backend of MainObjectStash

https://gerrit.wikimedia.org/r/542622

Change 542624 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] localisation: Log debug message for backend of MessageCache

https://gerrit.wikimedia.org/r/542624

Change 542622 merged by jenkins-bot:
[mediawiki/core@REL1_34] objectcache: Log debug message for backend of MainObjectStash

https://gerrit.wikimedia.org/r/542622

Krinkle updated the task description. (Show Details)

Change 542624 merged by jenkins-bot:
[mediawiki/core@master] localisation: Log debug message for backend of MessageCache

https://gerrit.wikimedia.org/r/542624

Change 543451 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@REL1_34] localisation: Log debug message for backend of MessageCache

https://gerrit.wikimedia.org/r/543451

Change 543451 merged by jenkins-bot:
[mediawiki/core@REL1_34] localisation: Log debug message for backend of MessageCache

https://gerrit.wikimedia.org/r/543451

Krinkle updated the task description. (Show Details)Wed, Oct 16, 10:40 PM

Change 543725 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] session: Add debug message for the used store class

https://gerrit.wikimedia.org/r/543725

Change 543725 merged by jenkins-bot:
[mediawiki/core@master] session: Add debug message for the used store class

https://gerrit.wikimedia.org/r/543725

Change 544188 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@REL1_34] session: Add debug message for the used store class

https://gerrit.wikimedia.org/r/544188

Change 544188 merged by jenkins-bot:
[mediawiki/core@REL1_34] session: Add debug message for the used store class

https://gerrit.wikimedia.org/r/544188

Krinkle closed this task as Resolved.Sat, Oct 19, 7:39 PM
Krinkle updated the task description. (Show Details)