Page MenuHomePhabricator
Create Task
Maniphest T235066

Deprecate static FileJournal::factory()
Closed, ResolvedPublic
Actions

Description

FileJournal::factory() should become an internal method of FileBackendGroup. If this is not sufficient, a separate FileJournalFactory service should be introduced.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Deprecate FileJournal::factorySimetricalmediawiki/coremaster+45 -46
Customize query in gerrit

Event Timeline

daniel created this task.Oct 9 2019, 12:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2019, 12:50 PM
daniel renamed this task from Deprecate statix FileJournal::factory() to Deprecate static FileJournal::factory().Oct 9 2019, 12:50 PM
gerritbot added a comment.Oct 23 2019, 1:39 PM

Change 545562 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Deprecate FileJournal::factory

https://gerrit.wikimedia.org/r/545562

gerritbot added a project: Patch-For-Review.Oct 23 2019, 1:39 PM
• WDoranWMF triaged this task as High priority.Oct 23 2019, 4:46 PM
• WDoranWMF added a project: Platform Team Workboards (Clinic Duty Team).
• WDoranWMF moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.
gerritbot added a comment.Nov 4 2019, 2:42 PM

Change 545562 merged by jenkins-bot:
[mediawiki/core@master] Deprecate FileJournal::factory

https://gerrit.wikimedia.org/r/545562

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Nov 4 2019, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 4 2019, 3:10 PM
• mobrovac closed this task as Resolved.Nov 11 2019, 12:34 PM
• mobrovac assigned this task to daniel.
• mobrovac moved this task from Waiting for Review to Done on the Platform Team Workboards (Clinic Duty Team) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits