Page MenuHomePhabricator
Create Task
Maniphest T235578

[wmf.2-regression] Help panel: the cog icon is misaligned
Closed, ResolvedPublic
Actions

Description

In testwiki the cog icon- oo-ui-icon-settings - is misaligned.

Screen Shot 2019-10-15 at 3.56.25 PM.png (546×325 px, 57 KB)

Note: The display issue is present on desktop and mobile (both Android and iOS).

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.36.1mediawiki/coremaster+1 K -6 K
Remove `background` from settings buttonmediawiki/extensions/GrowthExperimentswmf/1.35.0-wmf.2+9 -4
ProcessDialog: Remove `margin-left` override from ActionWidgetoojs/uimaster+0 -4
Remove `background` from settings buttonmediawiki/extensions/GrowthExperimentsmaster+9 -4
Fix ActionWidget icon styling broken by 6689fe50461boojs/uimaster+9 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Oct 15 2019, 11:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2019, 11:18 PM
Catrope added a comment.Oct 15 2019, 11:53 PM

Regression rGOJU6689fe50461b: WikimediaUI theme: Use `px` instead of `em`s, which changed left: Nem; to margin-left: -Nem; for no apparent reason.

gerritbot added a comment.Oct 16 2019, 12:09 AM

Change 543246 had a related patch set uploaded (by Catrope; owner: Catrope):
[oojs/ui@master] Fix ActionWidget icon styling broken by 6689fe50461b

https://gerrit.wikimedia.org/r/543246

gerritbot added a project: Patch-For-Review.Oct 16 2019, 12:09 AM
gerritbot added a comment.Oct 16 2019, 1:14 AM

Change 543250 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] ProcessDialog: Remove margin-left override from ActionWidget

https://gerrit.wikimedia.org/r/543250

gerritbot added a comment.Oct 16 2019, 1:45 AM

Change 543254 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/GrowthExperiments@master] Remove background from settings button

https://gerrit.wikimedia.org/r/543254

gerritbot added a comment.Oct 16 2019, 1:50 AM

Change 543246 abandoned by Catrope:
Fix ActionWidget icon styling broken by 6689fe50461b

Reason:
Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/ /543254/

https://gerrit.wikimedia.org/r/543246

Catrope edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Oct 16 2019, 1:54 AM
Catrope moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Oct 16 2019, 1:59 AM

Change 543254 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Remove background from settings button

https://gerrit.wikimedia.org/r/543254

gerritbot added a comment.Oct 16 2019, 2:08 AM

Change 543261 had a related patch set uploaded (by Catrope; owner: VolkerE):
[mediawiki/extensions/GrowthExperiments@wmf/1.35.0-wmf.2] Remove background from settings button

https://gerrit.wikimedia.org/r/543261

gerritbot added a comment.Oct 16 2019, 2:18 AM

Change 543250 merged by jenkins-bot:
[oojs/ui@master] ProcessDialog: Remove margin-left override from ActionWidget

https://gerrit.wikimedia.org/r/543250

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.3; 2019-10-22).Oct 16 2019, 3:00 AM
gerritbot added a comment.Oct 16 2019, 4:13 PM

Change 543261 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.35.0-wmf.2] Remove background from settings button

https://gerrit.wikimedia.org/r/543261

Stashbot added a comment.Oct 16 2019, 4:17 PM

Mentioned in SAL (#wikimedia-operations) [2019-10-16T16:17:54Z] <catrope@deploy1001> Synchronized php-1.35.0-wmf.2/extensions/GrowthExperiments/: Fix help panel button alignment (T235578) (duration: 01m 02s)

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.2; 2019-10-15); removed MW-1.35-notes (1.35.0-wmf.3; 2019-10-22).Oct 16 2019, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 16 2019, 5:10 PM
Etonkovidova closed this task as Resolved.Oct 16 2019, 8:32 PM
Etonkovidova claimed this task.
gerritbot added a comment.Dec 5 2019, 10:33 PM

Change 554963 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.36.0

https://gerrit.wikimedia.org/r/554963

gerritbot added a project: Patch-For-Review.Dec 5 2019, 10:33 PM
gerritbot added a comment.Dec 12 2019, 1:18 AM

Change 554963 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.36.1

https://gerrit.wikimedia.org/r/554963

Maintenance_bot removed a project: Patch-For-Review.Dec 12 2019, 2:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL