Page MenuHomePhabricator
Create Task
Maniphest T236005

PageTranslation: `tpt-duplicate` message should have an error class
Closed, ResolvedPublic
Actions

Description

As a translation admin,
When I go to mark a page for translation,
I want errors such as tpt-duplicate ("Translation unit name 1 is used more than once") to have a errorbox class, similar to the error from unbalanced translate tags
So that I can more easily see that there is an error, rather than hitting "Mark this version for translation" and only then realizing that there is an issue

Details

SubjectRepoBranchLines +/-
Add `errorbox` class to duplicate translation units messagemediawiki/extensions/Translatemaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Oct 21 2019, 1:52 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptOct 21 2019, 1:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Oct 21 2019, 1:53 AM

Change 544541 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Add errorbox class to duplicate translation units message

https://gerrit.wikimedia.org/r/544541

gerritbot added a project: Patch-For-Review.Oct 21 2019, 1:53 AM
Masumrezarock100 triaged this task as Medium priority.Oct 21 2019, 2:21 AM
Masumrezarock100 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.
Masumrezarock100 subscribed.
abi_ moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.Oct 22 2019, 12:48 PM
abi_ subscribed.

Works well, tested. See screenshot below,

image.png (480×965 px, 25 KB)

Reported T236153: Show tpt-duplicate error message only once for a translation unit to address the issue with the message appearing multiple times.

abi_ added projects: Language-Team (Language-2019-October-December), Unplanned-Sprint-Work.Oct 22 2019, 12:54 PM
abi_ moved this task from Backlog to Recheck after deployment on the Language-Team (Language-2019-October-December) board.
gerritbot added a comment.Oct 22 2019, 1:33 PM

Change 544541 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Add errorbox class to duplicate translation units message

https://gerrit.wikimedia.org/r/544541

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 22 2019, 2:14 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 22 2019, 2:14 PM
DannyS712 closed this task as Resolved.Oct 31 2019, 4:45 AM
DannyS712 moved this task from Awaiting review and deployment to Merged on the User-DannyS712 board.Nov 26 2019, 11:54 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits