Page MenuHomePhabricator
Create Task
Maniphest T236153

Show tpt-duplicate error message only once for a translation unit
Closed, ResolvedPublic
Actions

Description

When marking a page for translation, if a translation unit is repeated twice, the error message also appears twice. This can be avoided.

See screenshot below,

image.png (480×965 px, 25 KB)

Details

SubjectRepoBranchLines +/-
Prevent duplicate translation unit error from showing twicemediawiki/extensions/Translatemaster+7 -5
Customize query in gerrit

Related Objects

Event Timeline

abi_ created this task.Oct 22 2019, 12:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2019, 12:43 PM
abi_ triaged this task as Low priority.Oct 22 2019, 12:44 PM
abi_ moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.
abi_ mentioned this in T236005: PageTranslation: `tpt-duplicate` message should have an error class.Oct 22 2019, 12:48 PM
Florian subscribed.Nov 2 2019, 6:02 PM

Imported into Google-Code-in-2019 as https://codein.withgoogle.com/dashboard/tasks/5176453134548992/
I'm mentoring this task as well :)

Florian added a project: Google-Code-in-2019.Nov 2 2019, 6:05 PM
Urbanecm moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board.Nov 2 2019, 9:32 PM
Urbanecm subscribed.
In T236153#5628701, @Florian wrote:

Imported into Google-Code-in-2019 as https://codein.withgoogle.com/dashboard/tasks/5176453134548992/
I'm mentoring this task as well :)

Moving to appropriate column then!

Pppery claimed this task.Dec 5 2019, 2:34 AM
Pppery subscribed.

This feels like it was almost too easy for a GCI task, given how little time it took me to code.

Reedy subscribed.Dec 5 2019, 2:39 AM
In T236153#5714415, @Pppery wrote:

This feels like it was almost too easy for a GCI task, given how little time it took me to code.

Many people have different skill levels. So there will be tasks that are easy for some, and harder for others

gerritbot added a comment.Dec 5 2019, 3:01 AM

Change 554665 had a related patch set uploaded (by Pppery; owner: Pppery):
[mediawiki/extensions/Translate@master] Prevent duplicate translation unit error from showing twice

https://gerrit.wikimedia.org/r/554665

gerritbot added a project: Patch-For-Review.Dec 5 2019, 3:01 AM
Pppery added a comment.Dec 5 2019, 3:10 AM

The actual behavior I noticed and wrote a patch to fix was that the error message shows up twice if you use the same translation unit name three times in one page. It is possible that there is some other cause for this duplicate error message that I was unable to reproduce and this patch may not fix.

Nikerabbit closed this task as Resolved.Dec 16 2019, 10:14 AM
Nikerabbit removed a project: Patch-For-Review.
gerritbot added a comment.Dec 16 2019, 11:08 AM

Change 554665 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Prevent duplicate translation unit error from showing twice

https://gerrit.wikimedia.org/r/554665

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.11; 2019-12-17).Dec 16 2019, 12:01 PM
Pppery removed a project: good first task.Dec 16 2019, 12:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits