Page MenuHomePhabricator

Mount Popper Component
Closed, ResolvedPublic

Description

The popper component should be mounted, so that it appears according to the popper state in the Vuex store.

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterTR: Center popper (relative to icon), set background
mediawiki/extensions/Wikibase : masterTR: mount popper in App.vue

Event Timeline

hoo created this task.Nov 8 2019, 3:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 8 2019, 3:22 PM

Change 550433 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] TR: mount popper in App.vue

https://gerrit.wikimedia.org/r/550433

Change 550433 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: mount popper in App.vue

https://gerrit.wikimedia.org/r/550433

Change 550676 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] TR: Center popper (relative to icon), set background

https://gerrit.wikimedia.org/r/550676

hoo removed a project: Patch-For-Review.

I think we're done here, the popper is now properly mounted to the tainted icon. Everything else (styling, wording, …) is out of scope for this task.

Change 550676 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Center popper (relative to icon), set background

https://gerrit.wikimedia.org/r/550676

Lydia_Pintscher closed this task as Resolved.Nov 16 2019, 4:39 PM
Lydia_Pintscher claimed this task.
Lydia_Pintscher added a subscriber: Lydia_Pintscher.

\o/