Page MenuHomePhabricator
Create Task
Maniphest T237734

Mount Popper Component
Closed, ResolvedPublic
Actions

Description

The popper component should be mounted, so that it appears according to the popper state in the Vuex store.

Details

SubjectRepoBranchLines +/-
TR: Center popper (relative to icon), set backgroundmediawiki/extensions/Wikibasemaster+20 -18
TR: mount popper in App.vuemediawiki/extensions/Wikibasemaster+131 -8
Customize query in gerrit

Event Timeline

hoo created this task.Nov 8 2019, 3:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 8 2019, 3:22 PM
Tarrow added a project: Wikidata-Tainted-References-Sprint5.Nov 11 2019, 10:59 AM
Tarrow moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint5 board.Nov 11 2019, 3:08 PM
gerritbot added a comment.Nov 12 2019, 9:51 AM

Change 550433 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] TR: mount popper in App.vue

https://gerrit.wikimedia.org/r/550433

gerritbot added a project: Patch-For-Review.Nov 12 2019, 9:51 AM
Tarrow moved this task from Doing to Peer Review on the Wikidata-Tainted-References-Sprint5 board.Nov 12 2019, 10:06 AM
gerritbot added a comment.Nov 13 2019, 12:51 PM

Change 550433 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: mount popper in App.vue

https://gerrit.wikimedia.org/r/550433

Maintenance_bot removed a project: Patch-For-Review.Nov 13 2019, 1:10 PM
gerritbot added a comment.Nov 13 2019, 1:26 PM

Change 550676 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] TR: Center popper (relative to icon), set background

https://gerrit.wikimedia.org/r/550676

gerritbot added a project: Patch-For-Review.Nov 13 2019, 1:26 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 13 2019, 2:01 PM
hoo moved this task from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint5 board.Nov 15 2019, 12:32 PM
hoo removed a project: Patch-For-Review.

I think we're done here, the popper is now properly mounted to the tainted icon. Everything else (styling, wording, …) is out of scope for this task.

gerritbot added a comment.Nov 15 2019, 12:45 PM

Change 550676 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Center popper (relative to icon), set background

https://gerrit.wikimedia.org/r/550676

Lydia_Pintscher closed this task as Resolved.Nov 16 2019, 4:39 PM
Lydia_Pintscher claimed this task.
Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Tainted-References-Sprint5 board.
Lydia_Pintscher subscribed.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL