Page MenuHomePhabricator

deployment-prep database updater broken due to unsupported comments in dblist files
Closed, ResolvedPublic

Description

https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/ is broken with:

Exception: ('command: ', "echo '# NOTE: This file is automatically generated. Do not try to edit it directly.'; /usr/local/bin/mwscript update.php --wiki=# NOTE: This file is automatically generated. Do not try to edit it directly. --quick", 'output: ', '# NOTE: This file is automatically generated. Do not try to edit it directly.\nno version entry for #.\nFatal error: no version entry for #.\n in /srv/mediawiki-staging/multiversion/MWMultiVersion.php on line 423\n')

https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/545411/ adds a comment at the top of the dblist files:

# NOTE: This file is automatically generated. Do not try to edit it directly.

But that is not supported by the wmf-beta-update-databases script despite https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/553200/2/modules/beta/files/wmf-beta-update-databases.py

Event Timeline

hashar created this task.Thu, Nov 28, 11:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Nov 28, 11:32 AM
hashar triaged this task as High priority.Thu, Nov 28, 11:33 AM

Mentioned in SAL (#wikimedia-releng) [2019-11-28T11:40:24Z] <hashar> deployment-prep: rebased puppet. Notably to fix wmf-beta-update-databases ( https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/553200/ ) # T239399

hashar closed this task as Resolved.Thu, Nov 28, 11:46 AM
hashar claimed this task.