Page MenuHomePhabricator
Create Task
Maniphest T239475

Validate input and inform the user about violations
Closed, ResolvedPublic
Actions

Description

We have this:
When submitting data, the API will validate before actually storing it, but we're not showing those errors in the UI.

We want this:
When user input is invalid, we should inform them about any errors when submitting them, and allow them to recover from the errors without losing their input.

Acceptance Criteria:

  • Users are informed about errors
  • Users can recover from errors without losing their previous work

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Allow 'property' param in wbparsevalue to determine datatypemediawiki/extensions/Wikibasemaster+106 -3
Fix error handling when failing to submit statementsmediawiki/extensions/WikibaseMediaInfomaster+53 -34
Customize query in gerrit

Related Objects
Search...

Event Timeline

matthiasmullie created this task.Nov 29 2019, 2:13 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptNov 29 2019, 2:13 PM
matthiasmullie renamed this task from Validate values (and inform the user about violations) before attempting to submit them to Validate input and inform the user about violations.Nov 29 2019, 2:15 PM
matthiasmullie mentioned this in T231994: Add support for url data type (top-level statements and qualifiers).
matthiasmullie edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
matthiasmullie moved this task from Incoming to Doing on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Nov 29 2019, 2:17 PM

Change 553731 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/Wikibase@master] Allow 'property' param in wbparsevalue to determine datatype

https://gerrit.wikimedia.org/r/553731

gerritbot added a project: Patch-For-Review.Nov 29 2019, 2:17 PM
matthiasmullie moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Nov 29 2019, 4:05 PM
gerritbot added a comment.Nov 29 2019, 4:07 PM

Change 553754 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix error handling when failing to submit statements

https://gerrit.wikimedia.org/r/553754

gerritbot added a comment.Dec 12 2019, 11:49 AM

Change 553754 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix error handling when failing to submit statements

https://gerrit.wikimedia.org/r/553754

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.11; 2019-12-17).Dec 12 2019, 12:00 PM
gerritbot added a comment.Dec 12 2019, 2:15 PM

Change 553731 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Allow 'property' param in wbparsevalue to determine datatype

https://gerrit.wikimedia.org/r/553731

matthiasmullie updated the task description. (Show Details)Dec 17 2019, 5:42 PM
matthiasmullie updated the task description. (Show Details)
matthiasmullie moved this task from Code Review to Verify on Production on the Structured-Data-Backlog (Current Work) board.
matthiasmullie closed this task as Resolved.Dec 19 2019, 9:17 AM

Submit errors are now being displayed

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits