Page MenuHomePhabricator
Create Task
Maniphest T239529

Create test cases
Open, MediumPublic
Actions

Description

The code needs test cases. A set of PGN games needs to be compiled which test the various aspects of the PGN standard, especially:

  • Seven tag roster (STR)
    • Input out of order -> export in order
  • Additional tags
    • Always export after STR
    • Always export in alphabetical order
    • Test on input where tags are mixed with STR
  • Comments
    • Handles brace comments
    • Handles rest of line comments
  • Move numbers
    • Input with superfluous move numbers
    • Input with no move numbers
    • Input with multiple spaces between move numbers and symbols
    • Export in proper standard game notation (e.g. 1. e4 e5 2. c3 ...)
  • Symbols
    • Tests all continuation characters ("_", "+", "#", "=", ":", "-", a-zA-Z, 0-9)
  • Variations

Details

SubjectRepoBranchLines +/-
ChessBrowser: PgnParser and unit testsmediawiki/extensions/ChessBrowsermaster+6 K -648
layout: Configure tests for ChessBrowser extensionintegration/configmaster+6 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Wugapodes created this task.Dec 1 2019, 8:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 1 2019, 8:30 AM
Wugapodes triaged this task as Medium priority.Dec 1 2019, 8:30 AM
Wugapodes added a comment.Dec 1 2019, 8:52 AM

Probably helpful to read this man page on writing tests for extensions. The necessary tests will have to cover much more than what is stated in the original task, but those are a good place to start.

Wugapodes claimed this task.Dec 2 2019, 10:29 AM
Wugapodes moved this task from Planned Features to In Progress on the ChessBrowser board.
Wugapodes added a comment.Dec 2 2019, 10:42 AM

I've got tests working for the __construct(), cut(), getChar(), and parseVariation() functions of PgnParser, as well as test for the exceptions they throw.

gerritbot added a comment.Dec 3 2019, 2:33 AM

Change 554214 had a related patch set uploaded (by Wugapodes; owner: Wugapodes):
[mediawiki/extensions/ChessBrowser@master] Unit tests for PgnParser and related bug fixes

https://gerrit.wikimedia.org/r/554214

gerritbot added a project: Patch-For-Review.Dec 3 2019, 2:33 AM
gerritbot added a comment.Dec 7 2019, 1:46 AM

Change 554364 had a related patch set uploaded (by Wugapodes; owner: Wugapodes):
[integration/config@master] layout: Configure tests for ChessBrowser extension

https://gerrit.wikimedia.org/r/554364

gerritbot added a comment.Dec 9 2019, 5:49 PM

Change 554364 merged by jenkins-bot:
[integration/config@master] layout: Configure tests for ChessBrowser extension

https://gerrit.wikimedia.org/r/554364

Wugapodes moved this task from In Progress to Stalled on the ChessBrowser board.Dec 12 2019, 8:29 PM
Wugapodes added a comment.Dec 12 2019, 8:39 PM

Merging of the patch is prevented by T240611 and T240612 which result in build failures. This task is stalled until the source of those build errors is found and fixed.

Wugapodes closed subtask T240611: SpecialPageFatalTest::testSpecialPageDoesNotFail error with data set "RunJobs" as Resolved.Dec 12 2019, 9:28 PM
Wugapodes moved this task from Stalled to In Progress on the ChessBrowser board.
gerritbot added a comment.Dec 18 2019, 1:05 AM

Change 554214 merged by jenkins-bot:
[mediawiki/extensions/ChessBrowser@master] ChessBrowser: PgnParser and unit tests

https://gerrit.wikimedia.org/r/554214

Maintenance_bot removed a project: Patch-For-Review.Dec 18 2019, 1:11 AM
Wugapodes moved this task from In Progress to Stalled on the ChessBrowser board.Jan 2 2020, 7:41 AM
Kipod subscribed.Jan 2 2020, 2:56 PM

i would add specific chess cases, to verify correct pgn parsing:

  1. en passant
  2. castling
  3. promotion

WRT castling, if we are to support chess960 (the pure-JS script does. it seems to work but not thoroughly tested), castling is the most meaningful challenge, as initial positions of king and rooks varies.

also add some negative tests, specifically, feed it illegal/corrupted/empty etc. PGN, and expect sane output.

peace.

Wugapodes added a comment.Jan 9 2020, 1:44 AM

@Kipod the changes in 563005 implement some minimal tests for those three cases. The code currently only supports castling in standard board set ups, though presumably that can be changed at some point in the future if/when we can support chess960. You can see on line 152 of ChessParser.php that the source and target squares of the rook are hardcoded, but could be generalized to "other side of the king" in order to support non-standard start positions.

Wugapodes added a subtask: T246736: Reduce CRAP in FenParser0x88.Mar 3 2020, 6:25 AM
Wugapodes removed Wugapodes as the assignee of this task.Feb 7 2022, 12:56 AM
Wugapodes moved this task from Stalled to Backlog on the ChessBrowser board.Fri, Apr 19, 12:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL