FenParser0x88 test fails
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Wugapodes
	Mar 4 2020, 1:12 AM

Description

Steps to Reproduce:

Create a FenParser0x88 instance using the following FEN: r1bq1rk1/pp1pppbp/4n1p1/2pNP3/3nQ1PP/5N2/PPPP1P2/R1B1KB1R b KQ - 2 11
Call the move() method with directions to move the black knight to f3
Call the getNotation() method to examine the resulting notation

Actual Results:

Nxf3

Expected Results:

Nxf3+

Details

	Subject	Repo	Branch	Lines +/-
	Testing: Tests for FenParser0x88 and related fixes	mediawiki/extensions/ChessBrowser	master	+538 -17
	Revert "Remove unused FenParser0x88::getNotation"	mediawiki/extensions/ChessBrowser	master	+13 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T239529 Create test cases
Open		None	T246736 Reduce CRAP in FenParser0x88
Resolved	BUG REPORT	Wugapodes	T246856 FenParser0x88 test fails

Event Timeline

Wugapodes created this task.Mar 4 2020, 1:12 AM

Change 576491 had a related patch set uploaded (by Wugapodes; owner: Wugapodes):
[mediawiki/extensions/ChessBrowser@master] Testing: Tests for FenParser0x88

https://gerrit.wikimedia.org/r/576491

gerritbot added a project: Patch-For-Review.Mar 4 2020, 1:13 AM

Wugapodes renamed this task from FenParser0x88 tests fail to FenParser0x88 test fails.Mar 4 2020, 1:14 AM

Wugapodes updated the task description. (Show Details)

Wugapodes removed a project: Patch-For-Review.

Wugapodes claimed this task.Mar 5 2020, 3:03 AM

Change 579047 had a related patch set uploaded (by Wugapodes; owner: Wugapodes):
[mediawiki/extensions/ChessBrowser@master] Revert "Remove unused FenParser0x88::getNotation"

https://gerrit.wikimedia.org/r/579047

gerritbot added a project: Patch-For-Review.Mar 11 2020, 8:07 PM

Change 579047 abandoned by Wugapodes:
Revert "Remove unused FenParser0x88::getNotation"

Reason:
See https://www.webtipblog.com/unit-testing-private-methods-and-properties-with-phpunit/

https://gerrit.wikimedia.org/r/579047

Change 576491 had a related patch set uploaded (by Wugapodes; owner: Wugapodes):
[mediawiki/extensions/ChessBrowser@master] Testing: Tests for FenParser0x88 and related fixes

https://gerrit.wikimedia.org/r/576491

Wugapodes moved this task from Needs triage to In Progress on the ChessBrowser board.Jul 4 2020, 9:51 PM

Change 576491 merged by jenkins-bot:

[mediawiki/extensions/ChessBrowser@master] Testing: Tests for FenParser0x88 and related fixes

https://gerrit.wikimedia.org/r/576491

Restricted Repository Identity mentioned this in rECHB572b78fb1017: Testing: Tests for FenParser0x88 and related fixes.Apr 30 2021, 12:41 AM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 30 2021, 2:00 AM

This too seems like it could be closed, right @Wugapodes ?

Wugapodes closed this task as Resolved.Sep 22 2021, 12:11 AM