We're getting deadlocks when the recurring queue consumer runs at the same time as the donations queue consumer.
Let's make the recurring queue consumer strictly responsible for starting/ending new subscriptions.
The normal donations queue consumer IS capable of handling some recurring payments, but we need to move a little bit of normalization from the recurring queue consumer to the main normalization function.
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| wikimedia/fundraising/SmashPig | master | +15 -5 | WIP send recurring payments to donations queue |
Change 556829 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] WIP send recurring payments to donations queue
So there is indeed some recurring-specific normalization happening in the RecurringQueueConsumer, mostly stuff specific to paypal messages. We'd have to move that over to someplace in the donations queue consumer before we merge the above patch.
The recurring-specific normalization has two parts: 1) finding the contribution_tracking_id and 2) dealing with paypal inconsistencies in migrating legacy to new subscription ID formats.