Page MenuHomePhabricator
Create Task
Maniphest T241017

eslint: re-enable one-var linter rule
Closed, ResolvedPublic
Actions

Description

https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/ChessBrowser/+/d7c388b3575f151a90b2ab04f15e12ca79d2bccc%5E%21/#F0 involved disabling eslint rule 'one-var'. As a follow up, it should be re-enabled, and the issues raised resolved.

Details

SubjectRepoBranchLines +/-
Technical debt: Re-enable `one-var` rule globallymediawiki/extensions/ChessBrowsermaster+51 -37
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Dec 18 2019, 1:07 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptDec 18 2019, 1:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Dec 18 2019, 1:08 AM

Change 558751 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ChessBrowser@master] Technical debt: Re-enable some disabled eslint rules

https://gerrit.wikimedia.org/r/558751

gerritbot added a project: Patch-For-Review.Dec 18 2019, 1:08 AM
DannyS712 moved this task from Needs triage to In Progress on the ChessBrowser board.Dec 18 2019, 1:53 AM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.
DannyS712 added a subscriber: Wugapodes.

@Wugapodes would you mind taking a look?

Wugapodes added a parent task: T241086: Pay off javascript technical debt.Dec 18 2019, 9:46 PM
Wugapodes renamed this task from eslint: re-enable some rules to eslint: re-enable one-var linter rule.Dec 18 2019, 9:48 PM
Wugapodes updated the task description. (Show Details)
Wugapodes mentioned this in T241086: Pay off javascript technical debt.Dec 18 2019, 9:51 PM
gerritbot added a comment.Dec 18 2019, 10:08 PM

Change 558751 merged by jenkins-bot:
[mediawiki/extensions/ChessBrowser@master] Technical debt: Re-enable one-var rule globally

https://gerrit.wikimedia.org/r/558751

DannyS712 closed this task as Resolved.Dec 18 2019, 10:09 PM
DannyS712 removed a project: Patch-For-Review.
DannyS712 moved this task from In Progress to Completed on the ChessBrowser board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL