Pay off javascript technical debt
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Wugapodes
	Dec 18 2019, 9:45 PM

Description

Tracking task to keep track of changes which pay off technical debt incurred by change 554214

Rules disabled which need re-enabled:

one-var (T241017)
vars-on-top (T241087)
no-useless-escape (T241546)
no-jquery/variable-pattern (T241108)
no-jquery/no-constructor-attributes (T241357)

Inline suppression of rules that should be removed, with the underlying issue resolved: https://codesearch.wmflabs.org/search/?q=eslint&i=nope&files=ext%5C.chessViewer%5C.core%5C.js&repos=Extension:ChessBrowser

Details

	Subject	Repo	Branch	Lines +/-
	Javascript: Clean up, reduce technical debt	mediawiki/extensions/ChessBrowser	master	+49 -50

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Wugapodes	T240742 Minimize client-side footprint
Resolved	DannyS712	T241086 Pay off javascript technical debt
Resolved	DannyS712	T241017 eslint: re-enable one-var linter rule
Resolved	DannyS712	T241087 eslint: re-enable vars-on-top linter rule
Resolved	DannyS712	T241108 eslint: re-enable variable-pattern linter rule
Resolved	DannyS712	T241357 eslint: re-enable no-constructor-attributes linter rule
Resolved	DannyS712	T241546 eslint: re-enable no-useless-escape linter rule

Event Timeline

Wugapodes created this task.Dec 18 2019, 9:45 PM

Wugapodes added a subtask: T241017: eslint: re-enable one-var linter rule.

Wugapodes triaged this task as Low priority.Dec 18 2019, 9:51 PM

Wugapodes updated the task description. (Show Details)

DannyS712 closed subtask T241017: eslint: re-enable one-var linter rule as Resolved.Dec 18 2019, 10:09 PM

DannyS712 added a subtask: T241087: eslint: re-enable vars-on-top linter rule.

DannyS712 updated the task description. (Show Details)

DannyS712 added a project: Technical-Debt.Dec 18 2019, 10:23 PM

DannyS712 moved this task from Needs triage to In Progress on the ChessBrowser board.

DannyS712 closed subtask T241087: eslint: re-enable vars-on-top linter rule as Resolved.Dec 19 2019, 7:56 AM

DannyS712 added a subtask: T241108: eslint: re-enable variable-pattern linter rule.Dec 19 2019, 8:01 AM

DannyS712 updated the task description. (Show Details)

DannyS712 closed subtask T241108: eslint: re-enable variable-pattern linter rule as Resolved.Dec 21 2019, 1:13 AM

DannyS712 added a subtask: T241357: eslint: re-enable no-constructor-attributes linter rule.Dec 23 2019, 8:52 AM

DannyS712 updated the task description. (Show Details)

DannyS712 closed subtask T241357: eslint: re-enable no-constructor-attributes linter rule as Resolved.Dec 29 2019, 11:54 PM

DannyS712 added a subtask: T241546: eslint: re-enable no-useless-escape linter rule.

DannyS712 updated the task description. (Show Details)Dec 29 2019, 11:57 PM

DannyS712 claimed this task.Dec 29 2019, 11:59 PM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptDec 29 2019, 11:59 PM

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.Dec 29 2019, 11:59 PM

DannyS712 updated the task description. (Show Details)Dec 30 2019, 2:03 AM

DannyS712 closed subtask T241546: eslint: re-enable no-useless-escape linter rule as Resolved.Jan 2 2020, 12:06 AM

Change 561714 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ChessBrowser@master] Javascript: Clean up, reduce technical debt

https://gerrit.wikimedia.org/r/561714

gerritbot added a project: Patch-For-Review.Jan 3 2020, 12:20 AM

Change 561714 merged by jenkins-bot:
[mediawiki/extensions/ChessBrowser@master] Javascript: Clean up, reduce technical debt

https://gerrit.wikimedia.org/r/561714