eslint: re-enable vars-on-top linter rule
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DannyS712
	Dec 18 2019, 10:10 PM

Description

https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/ChessBrowser/+/d7c388b3575f151a90b2ab04f15e12ca79d2bccc%5E%21/#F0 involved disabling eslint rule 'vars-on-top'. As a follow up, it should be re-enabled, and the issues raised resolved.

Details

	Subject	Repo	Branch	Lines +/-
	Technical debt: Re-enable `vars-on-top` rule globally	mediawiki/extensions/ChessBrowser	master	+33 -31

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Wugapodes	T240742 Minimize client-side footprint
Resolved	DannyS712	T241086 Pay off javascript technical debt
Resolved	DannyS712	T241087 eslint: re-enable vars-on-top linter rule

Event Timeline

DannyS712 created this task.Dec 18 2019, 10:10 PM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptDec 18 2019, 10:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DannyS712 added a parent task: T241086: Pay off javascript technical debt.Dec 18 2019, 10:10 PM

DannyS712 mentioned this in T241086: Pay off javascript technical debt.

Change 559216 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ChessBrowser@master] Technical debt: Re-enable vars-on-top rule globally

https://gerrit.wikimedia.org/r/559216

gerritbot added a project: Patch-For-Review.Dec 18 2019, 10:11 PM