Page MenuHomePhabricator
Create Task
Maniphest T241357

eslint: re-enable no-constructor-attributes linter rule
Closed, ResolvedPublic
Actions

Description

Same as previous

Details

SubjectRepoBranchLines +/-
Technical debt: Re-enable `no-constructor-attributes` rule globallymediawiki/extensions/ChessBrowsermaster+18 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Dec 23 2019, 8:51 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptDec 23 2019, 8:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 added a parent task: T241086: Pay off javascript technical debt.Dec 23 2019, 8:52 AM
DannyS712 mentioned this in T241086: Pay off javascript technical debt.
gerritbot added a comment.Dec 23 2019, 8:53 AM

Change 560374 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ChessBrowser@master] Technical debt: Re-enable no-constructor-attributes rule globally

https://gerrit.wikimedia.org/r/560374

gerritbot added a project: Patch-For-Review.Dec 23 2019, 8:53 AM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Dec 23 2019, 9:04 AM
DannyS712 moved this task from Needs triage to In Progress on the ChessBrowser board.
DannyS712 added a subscriber: Wugapodes.

@Wugapodes would you mind taking a look?

gerritbot added a comment.Dec 29 2019, 9:46 PM

Change 560374 merged by jenkins-bot:
[mediawiki/extensions/ChessBrowser@master] Technical debt: Re-enable no-constructor-attributes rule globally

https://gerrit.wikimedia.org/r/560374

Maintenance_bot removed a project: Patch-For-Review.Dec 29 2019, 10:10 PM
DannyS712 closed this task as Resolved.Dec 29 2019, 11:54 PM
DannyS712 moved this task from In Progress to Completed on the ChessBrowser board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits