Page MenuHomePhabricator
Create Task
Maniphest T242389

PTF Checkbox does not align right to left on Desktop Small Banner
Closed, ResolvedPublic
Actions

Description

Summary:
It was noticed during testing today that the Pay The Fee checkbox does not align from right to left in languages that are oriented in this fashion.

PTFNotRightOriented.png (646×709 px, 59 KB)

Steps to Reproduce:

  1. Open https://he.wikipedia.org/w/index.php?title=%D7%A0%D7%90%D7%A1%22%D7%90&banner=B1920_1216_en6C_dsk_p2_sm_endowment_template&country=IL
  2. Observe checkbox is still on the left side of the banner

Expected Results:
The PTF checkbox should appear on the right side of the banner in languages that are written from right to left

Actual Results:
Currently the PTF checkbox does not align to the right side of the banner in languages written from right to left

Related Objects

Mentioned Here
P3 nagios-plugin-files

Event Timeline

• jbolorinos-ctr created this task.Jan 9 2020, 11:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 9 2020, 11:43 PM
• jbolorinos-ctr removed subscribers: Pcoombe, spatton, Aklapper.Jan 10 2020, 12:11 AM
Pcoombe moved this task from Backlog to RTL on the Wikimedia-Fundraising-Banners board.Feb 19 2020, 4:59 PM
• jbolorinos-ctr triaged this task as Medium priority.Feb 19 2020, 5:47 PM

Updating priority to P3 since Big Bundle campaign needs this, but only affects one country

Pcoombe claimed this task.Feb 26 2020, 9:44 PM

@jbolorinos-ctr This should be fixed now, please can you confirm? https://he.wikipedia.org/?banner=B1920_0301_mlWW_dsk_p1_lg_cnt&country=IL

I also double checked and it appears RTL languages don't need to mirror the checkmark itself, or at least we don't in the standard MediaWiki interface.

• jbolorinos-ctr added a comment.Feb 26 2020, 10:17 PM

Hey @Pcoombe

That's so interesting, so the checkbox must be aligned RTL but not the checkmark itself? So weird!!!

Anyways, I was able to verify the checkbox is aligned RTL on Desktop Large now, but not on Desktop Small unfortunately. Can we please update that code as well to align the checkbox?

Pcoombe added a comment.Feb 27 2020, 4:04 PM

Sorry about that @jbolorinos-ctr. Desktop Small should be fixed now, and I also made some small fixes to button positioning on RTL:
https://he.wikipedia.org/w/index.php?title=%D7%A0%D7%90%D7%A1%22%D7%90&banner=B1920_0301_mlWW_dsk_p2_sm_cnt&country=IL

• jbolorinos-ctr added a comment.Feb 27 2020, 9:28 PM

No problem Peter! This is why it's good practice to verify these fixes! :)

image.png (814×1 px, 165 KB)

I've now verified this fix on Desktop Small, so closing this as Resolved now.

Pcoombe closed this task as Resolved.Feb 28 2020, 11:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL