Page MenuHomePhabricator
Create Task
Maniphest T243171

require ipaddress package instead of ipaddr for Python 2
Closed, ResolvedPublic
Actions

Description

ipaddr package is superseeded by ipaddress which is a backport of Python 3 Standard. [1]
Also make it mandatory für Python 2 to prevent different behaviour on Python 2 and 3

[1] https://pypi.org/project/ipaddr/

Details

SubjectRepoBranchLines +/-
[cleanup] Remove deprecated ip submodulepywikibot/coremaster+3 -87
[deps] require ipaddress for Python 2pywikibot/coremaster+82 -100
Customize query in gerrit

Related Objects
Search...

Event Timeline

Xqt created this task.Jan 20 2020, 9:19 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJan 20 2020, 9:19 AM
Xqt triaged this task as Medium priority.Jan 20 2020, 9:19 AM
gerritbot added a comment.Jan 20 2020, 12:25 PM

Change 566013 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [deps] require ipaddress for Python 2

https://gerrit.wikimedia.org/r/566013

gerritbot added a project: Patch-For-Review.Jan 20 2020, 12:25 PM
Xqt claimed this task.Jan 20 2020, 1:33 PM
Xqt added a parent task: T243770: Pywikibot Python 2 compatibility (tracking).Jan 27 2020, 3:01 PM
Kizule moved this task from Backlog to Needs Review on the Pywikibot board.Feb 8 2020, 5:00 PM
gerritbot added a comment.Feb 11 2020, 2:09 PM

Change 566013 merged by jenkins-bot:
[pywikibot/core@master] [deps] require ipaddress for Python 2

https://gerrit.wikimedia.org/r/566013

Maintenance_bot removed a project: Patch-For-Review.Feb 11 2020, 2:10 PM
Xqt mentioned this in rPWBCde3cdc3796e3: [deps] require ipaddress for Python 2.Feb 11 2020, 2:11 PM
Xqt closed this task as Resolved.Feb 11 2020, 4:07 PM
gerritbot added a comment.May 8 2020, 7:08 PM

Change 595213 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [cleanup] Remove deprecatet ip submodule

https://gerrit.wikimedia.org/r/595213

gerritbot added a project: Patch-For-Review.May 8 2020, 7:08 PM
gerritbot added a comment.Jun 27 2020, 9:06 AM

Change 595213 merged by jenkins-bot:
[pywikibot/core@master] [cleanup] Remove deprecated ip submodule

https://gerrit.wikimedia.org/r/595213

Xqt mentioned this in rPWBC80b8923632eb: [cleanup] Remove deprecated ip submodule.Jun 27 2020, 9:08 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 27 2020, 9:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits