Add tests for SearchNearMatcher:: getNearMatch that cover case for language with variants
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Peter.ovchyn
	Jan 27 2020, 10:53 AM

Description

Please add one.

Motivation:

SearchNearMatcherTest::testNearMatch doesn't have a test case for a language with variants.
https://doc.wikimedia.org/cover/mediawiki-core/includes/search/SearchNearMatcher.php.html

Expected result:

More tests should be added.
SearchNearMatcher::getNearMatch should be covered 100% tests for language with variants.
SearchNearMatcher::getNearMatchInternal should be covered

Details

	Subject	Repo	Branch	Lines +/-
	search engine: Add tests for SearchNearMatcher	mediawiki/core	master	+122 -14

Customize query in gerrit

Event Timeline

Peter.ovchyn created this task.Jan 27 2020, 10:53 AM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJan 27 2020, 10:53 AM

Peter.ovchyn updated the task description. (Show Details)Jan 27 2020, 10:53 AM

Peter.ovchyn removed a parent task: T226833: Introduce LanguageConverterFactory service.Jan 31 2020, 9:49 AM

Peter.ovchyn moved this task from Backlog to Estimated/Estimation on the Platform Team Workboards (S&F Workboard) board.Feb 3 2020, 11:17 AM

daniel removed a project: Platform Engineering.Feb 5 2020, 7:28 PM

Peter.ovchyn moved this task from Estimated/Estimation to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Feb 10 2020, 10:34 AM

Change 571326 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/core@master] search engine: Add tests for SearchNearMatcher:: getNearMatch that cover case for language with variants

https://gerrit.wikimedia.org/r/571326

gerritbot added a project: Patch-For-Review.Feb 10 2020, 5:48 PM

96% of the lines are covered.

Peter.ovchyn moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Feb 10 2020, 7:09 PM

Peter.ovchyn added a project: Platform Engineering.

Peter.ovchyn removed a project: Platform Engineering.Feb 10 2020, 7:11 PM

Change 571326 merged by jenkins-bot:
[mediawiki/core@master] search engine: Add tests for SearchNearMatcher

https://gerrit.wikimedia.org/r/571326

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 13 2020, 5:00 PM

Peter.ovchyn moved this task from In Progress/In Review to Done on the Platform Team Workboards (S&F Workboard) board.Feb 24 2020, 9:10 AM

Peter.ovchyn closed this task as Resolved.Mar 3 2020, 6:02 PM

Winston_Sung removed a project: Patch-For-Review.Dec 27 2023, 6:10 PM