Page MenuHomePhabricator

Use idempotency headers in payment processing requests
Closed, ResolvedPublic2 Estimated Story Points

Event Timeline

Change 827615 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Adyen: use API idempotency header

https://gerrit.wikimedia.org/r/827615

This will help if we're worried that we are charging duplicates when we get a timeout making an API call and automatically retry.

This will NOT help with donors who actually submit the form twice in short succession due to not seeing the TY page for whatever reason. For those donors, maybe we keep a map in memcache of 'email + ip address' => order id . We set that before making an API call, then if the donor tries to donate and we see it's already there, we can check the status of the payment

Change 827615 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Adyen: use API idempotency header

https://gerrit.wikimedia.org/r/827615

Ejegg triaged this task as Medium priority.
Ejegg set Final Story Points to 2.
Ejegg moved this task from Q3 2021-2022 to Current Sprint on the Fundraising-Backlog board.

Looks like for Ingenico this is only available for 'Create Payment'

Change 828671 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Add UniqueId helper class, use for Adyen idempotence

https://gerrit.wikimedia.org/r/828671

Change 828672 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Use idempotence headers for Ingenico

https://gerrit.wikimedia.org/r/828672

Change 828671 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Add UniqueId helper class, use for Adyen idempotence

https://gerrit.wikimedia.org/r/828671

Change 828672 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Use idempotence headers for Ingenico

https://gerrit.wikimedia.org/r/828672

Change 830318 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] WIP fix Ingenico Auth for Idempotency headers

https://gerrit.wikimedia.org/r/830318

Change 830318 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Fix Ingenico Auth for Idempotency headers

https://gerrit.wikimedia.org/r/830318

Ejegg set the point value for this task to 2.
Ejegg changed Final Story Points from 2 to 4.