Page MenuHomePhabricator

Search page advanced search widget has multiple elements with the same id
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  1. Go to mediawiki.org
  2. Navigate till "Search" control and search for any text and hit enter .
  3. Navigate till "Advanced Search " control and expand it .

Actual Results:
After expanding the advanced search you can notice looking at the html that there are duplicate ids. this may affect accessibility of the page.

Expected Results:
Each id should be unique

Event Timeline

Restricted Application added a project: archived--TCB-Team. · View Herald TranscriptFeb 4 2020, 9:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper renamed this task from [Accessibility] Search page advanced search widget has multiple elements with the same id to Search page advanced search widget has multiple elements with the same id.Feb 4 2020, 10:03 PM
Aklapper added a project: Accessibility.

Change 570152 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Bkudiess-msft):
[mediawiki/extensions/AdvancedSearch@master] Fix duplicate expandable pane id and aria control

https://gerrit.wikimedia.org/r/570152

Change 570152 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Fix duplicate expandable pane id and aria control

https://gerrit.wikimedia.org/r/570152

@Bkudiess-msft: Hi, the patch in Gerrit has been merged. Can this task be resolved (via Add Action...Change Status in the dropdown menu), or is there more to do in this task? Asking as you are set as task assignee. Thanks in advance!

Aklapper closed this task as Resolved.May 17 2020, 10:02 AM

@Bkudiess-msft: Assuming this is resolved. Please reopen if I am wrong!