Page MenuHomePhabricator
Create Task
Maniphest T244295

Search page advanced search widget has multiple elements with the same id
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  1. Go to mediawiki.org
  2. Navigate till "Search" control and search for any text and hit enter .
  3. Navigate till "Advanced Search " control and expand it .

Actual Results:
After expanding the advanced search you can notice looking at the html that there are duplicate ids. this may affect accessibility of the page.

Expected Results:
Each id should be unique

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix duplicate expandable pane id and aria controlBkudiess-msftmediawiki/extensions/AdvancedSearchmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Bkudiess-msft created this task.Feb 4 2020, 9:39 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptFeb 4 2020, 9:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper renamed this task from [Accessibility] Search page advanced search widget has multiple elements with the same id to Search page advanced search widget has multiple elements with the same id.Feb 4 2020, 10:03 PM
Aklapper added a project: Accessibility.
gerritbot added a comment.Mar 8 2020, 9:24 AM

Change 570152 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Bkudiess-msft):
[mediawiki/extensions/AdvancedSearch@master] Fix duplicate expandable pane id and aria control

https://gerrit.wikimedia.org/r/570152

gerritbot added a project: Patch-For-Review.Mar 8 2020, 9:24 AM
gerritbot added a comment.Mar 8 2020, 9:29 AM

Change 570152 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Fix duplicate expandable pane id and aria control

https://gerrit.wikimedia.org/r/570152

thiemowmde mentioned this in rEASR25a1684f6163: Fix duplicate expandable pane id and aria control.Mar 8 2020, 9:31 AM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.23; 2020-03-10).Mar 8 2020, 10:01 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 8 2020, 10:10 AM
Aklapper added a comment.Mar 23 2020, 9:15 AM

@Bkudiess-msft: Hi, the patch in Gerrit has been merged. Can this task be resolved (via Add Action... → Change Status in the dropdown menu), or is there more to do in this task? Asking as you are set as task assignee. Thanks in advance!

Aklapper closed this task as Resolved.May 17 2020, 10:02 AM

@Bkudiess-msft: Assuming this is resolved. Please reopen if I am wrong!

thiemowmde merged a task: T242167: IDs must be unique across all elements on the page..Oct 4 2022, 6:49 AM
thiemowmde added subscribers: Akinwale-microsoft, Tam-edwin-microsoft.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits