Incorrect replacement of \u2022 with u2022 during imports for AndroidXML
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	abi_
	Feb 6 2020, 4:29 PM

Description

For Kiwix, during imports, \u2022 was replaced with u2022,

See https://translatewiki.net/w/i.php?title=Kiwix%3AAndroid.ui.pref_hide_toolbar_summary%2Feu&type=revision&diff=9243340&oldid=9108321 after this should change was made - 581b127#diff-c533bde4f259f63373679ba0e169ac32R44

This is obviously wrong and needs some investigation.

Event Timeline

abi_ created this task.Feb 6 2020, 4:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2020, 4:29 PM

Kelson added a project: affects-Kiwix-and-openZIM.Feb 6 2020, 5:26 PM

Kelson subscribed.

Culprit code: https://gerrit.wikimedia.org/g/mediawiki/extensions/Translate/+/0f1174455ce54d86e57a56ada33c589109d02a7a/ffs/AndroidXmlFFS.php#89

Option 1: Replace unicode escapes before stripcslashes by their unescaped equivalents
Option 2: Escape unicode escapes before stripcslashes so that they end up with one slash instead of zero

Kelson moved this task from TRIAGE to NORMAL on the affects-Kiwix-and-openZIM board.Apr 25 2020, 12:27 PM

Nikerabbit closed this task as a duplicate of T192062: \ does not roundtrip in AndroidXmlFFS.Aug 31 2020, 7:40 AM

Incorrect replacement of \u2022 with u2022 during imports for AndroidXMLClosed, DuplicatePublicActions

Description

Event Timeline

Incorrect replacement of \u2022 with u2022 during imports for AndroidXML
Closed, DuplicatePublic
Actions