Page MenuHomePhabricator
Create Task
Maniphest T244638

101: show(Edits|LogEntries|NewPages) are not properly analyzed in getUserSettings
Closed, ResolvedPublicBUG REPORT
Actions

Description

Hi. Reproducing steps.

  1. Your global watchlist should include some unseen log entries as a starting point.
  2. Global.js should include showLogEntries and showNewPages, both true, as a starting point.
  3. Open the global watchlist.
  4. Observe the log entries.
  5. Click on settings.
  6. Uncheck both boxes.
  7. Save.
  8. The global watchlist reappeas.
  9. Observe the log entries unexpectedly.
  10. The global.js was edited, both are false.
  11. Click on settings.
  12. Observe both the boxes checked unexpectedly.
  13. Uncheck and recheck them.
  14. Save.
  15. The global watchlist reappears.
  16. Observe the log entries.
  17. The global.js was edited, both are true.

Console content:

P10354
Thank you.

Event Timeline

IKhitron created this task.Feb 8 2020, 1:40 PM
Restricted Application assigned this task to DannyS712. · View Herald TranscriptFeb 8 2020, 1:40 PM
Restricted Application added a subscriber: DannyS712. · View Herald Transcript
IKhitron changed the task status from Open to Stalled.Feb 8 2020, 1:40 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptFeb 8 2020, 1:40 PM
Maintenance_bot moved this task from Unsorted to Global Watchlist on the User-DannyS712 board.Feb 8 2020, 2:15 PM
IKhitron updated the task description. (Show Details)Feb 9 2020, 1:12 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptFeb 9 2020, 1:12 PM
IKhitron changed the task status from Stalled to Open.Feb 9 2020, 1:12 PM
DannyS712 added a comment.Feb 9 2020, 1:19 PM

@IKhitron can you please expand the arrays to show the content?

DannyS712 added a comment.Feb 9 2020, 1:21 PM

Also, can you leave it after the first edit (setting the values to false), and then, when you go to the watchlist, wait a minute, and then hit refresh? It needs time to update the settings

IKhitron updated the task description. (Show Details)Feb 9 2020, 1:26 PM

Done the first part. What to you want me to take after the refresh? I can still see the log entries.

DannyS712 added a comment.EditedFeb 9 2020, 1:29 PM
In T244638#5862638, @IKhitron wrote:

Done the first part. What to you want me to take after the refresh? I can still see the log entries.

Can you expand the ...?
What wiki are you viewing the watchlist on?
Can you post the whole console (again, expanding the arrays and objects)?

Also, https://meta.wikimedia.org/wiki/User:IKhitron/global.js still says to show them...

IKhitron added a comment.Feb 9 2020, 1:37 PM
In T244638#5862643, @DannyS712 wrote:
In T244638#5862638, @IKhitron wrote:

Done the first part. What to you want me to take after the refresh? I can still see the log entries.

Can you expand the ...?

It is already expanded.

What wiki are you viewing the watchlist on?

Ruwiki.

Can you post the whole console (again, expanding the arrays and objects)?

Yes, but are syre? It's about a megabyte of text.

Also, https://meta.wikimedia.org/wiki/User:IKhitron/global.js still says to show them...

It's because I restore it each time, for your next question. See the history.

DannyS712 added a comment.Feb 9 2020, 1:41 PM
In T244638#5862660, @IKhitron wrote:
In T244638#5862643, @DannyS712 wrote:
In T244638#5862638, @IKhitron wrote:

Done the first part. What to you want me to take after the refresh? I can still see the log entries.

Can you expand the ...?

It is already expanded.

It doesn't show everything, but I'll add some debugging code to make it easier for you

What wiki are you viewing the watchlist on?

Ruwiki.

Can you post the whole console (again, expanding the arrays and objects)?

Yes, but are syre? It's about a megabyte of text.

Can you create a paste?

Also, https://meta.wikimedia.org/wiki/User:IKhitron/global.js still says to show them...

It's because I restore it each time, for your next question. See the history.

Sure, but just leave it as disabled for now

IKhitron added a comment.Feb 9 2020, 1:49 PM
In T244638#5862662, @DannyS712 wrote:

Can you create a paste?

https://pastebin.com/UEXq1Nyk

Sure, but just leave it as disabled for now

No problem

DannyS712 added a comment.Feb 9 2020, 1:56 PM
In T244638#5862666, @IKhitron wrote:
In T244638#5862662, @DannyS712 wrote:

Can you create a paste?

https://pastebin.com/UEXq1Nyk

Sure, but just leave it as disabled for now

No problem

I meant a phabricator paste (https://phabricator.wikimedia.org/paste/edit/form/14/)
I've added some more debug logic. Can you please:

  • Open your global watchlist
  • Open the console
  • Run console.log( GlobalWatchlist.debugLog );
  • And create a paste with the result?

It'll be a large output, and (as a warning) will include what pages are being shown (generally watchlists are private; if you want me to create a paste only visible to the two of us I can do that too)

IKhitron added a comment.Feb 9 2020, 3:23 PM
In T244638#5862667, @DannyS712 wrote:

I meant a phabricator paste (https://phabricator.wikimedia.org/paste/edit/form/14/)

Access Denied: Restricted Edit Configuration
You do not have permission to view this object.

I've added some more debug logic. Can you please:

  • Open your global watchlist
  • Open the console
  • Run console.log( GlobalWatchlist.debugLog );
  • And create a paste with the result?

It'll be a large output, and (as a warning) will include what pages are being shown (generally watchlists are private; if you want me to create a paste only visible to the two of us I can do that too)

How do I create a phabricator paste?

Masumrezarock100 subscribed.EditedFeb 9 2020, 4:37 PM
In T244638#5862693, @IKhitron wrote:
In T244638#5862667, @DannyS712 wrote:

I meant a phabricator paste (https://phabricator.wikimedia.org/paste/edit/form/14/)

Access Denied: Restricted Edit Configuration
You do not have permission to view this object.

The form for creating a paste on Phabricator is only visible to Trusted-Contributors and Phabricator admins (see configuration). That's why you can't access it. I can create the object for you if you want. But it would make more sense to let @DannyS712 handle this since he is the script maintainer and watchlist entries are considered private.

IKhitron added a comment.Feb 9 2020, 4:39 PM

I do not care how it will be done. Danny asked to create this paste.

Masumrezarock100 added a comment.Feb 9 2020, 4:52 PM
In T244638#5862712, @IKhitron wrote:

I do not care how it will be done. Danny asked to create this paste.

Ok. Created P10354. Edit the paste and copy-paste the console data to the "Text" field. If you are still having trouble, do let us know.

IKhitron added a comment.EditedFeb 9 2020, 4:57 PM

Thanks, done. Do not care if anyone will see my watchlists.

DannyS712 renamed this task from Show log entries and show new pages settings do not work. to 101: show(Edits|LogEntries|NewPages) are not properly analyzed in getUserSettings.Feb 9 2020, 7:15 PM
DannyS712 triaged this task as High priority.
DannyS712 changed the subtype of this task from "Task" to "Bug Report".
DannyS712 moved this task from Backlog to Ready for development on the DannyS712-Global_watchlist.js board.
DannyS712 added a comment.Feb 9 2020, 7:21 PM

Okay, try it now

IKhitron added a comment.Feb 9 2020, 7:24 PM

Great, thanks. What about the stable version?

Masumrezarock100 updated the task description. (Show Details)Feb 9 2020, 7:27 PM
DannyS712 added a comment.Feb 9 2020, 7:30 PM
In T244638#5862799, @IKhitron wrote:

Great, thanks. What about the stable version?

Back porting now

DannyS712 added a comment.Feb 9 2020, 7:32 PM
In T244638#5862799, @IKhitron wrote:

Great, thanks. What about the stable version?

Should be working

IKhitron added a comment.Feb 9 2020, 7:36 PM

Indeed. Thank you very much.

Masumrezarock100 closed this task as Resolved.Feb 9 2020, 7:38 PM

Looks good, resolving

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits