Page MenuHomePhabricator
Create Task
Maniphest T245271

Prevent browser autocomplete in the UsersMultiselectWidget in Special:Investigate
Closed, ResolvedPublic
Actions

Description

The HTMLTitlesMultiselectField passes input config through to the TitlesMultiselectWidget, allowing 'autocomplete' to be set to false. Do the same for the UsersMultiselectWidget.

(In the longer term, but beyond the scope of this task, these fields should be refactored to share more to reduce the need for duplication.)

Details

SubjectRepoBranchLines +/-
HTMLUsersMultiselectField: Pass through config for widget's inputmediawiki/coremaster+4 -0
SpecialInvestigate: Remove browser autocomplete from target widgetmediawiki/extensions/CheckUsermaster+3 -1
Customize query in gerrit

Event Timeline

Tchanders created this task.Feb 14 2020, 2:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2020, 2:00 PM
Tchanders added a project: CheckUser.Feb 14 2020, 2:00 PM
gerritbot added a comment.Feb 14 2020, 3:15 PM

Change 572254 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] HTMLUsersMultiselectField: Pass through config for widget's input

https://gerrit.wikimedia.org/r/572254

gerritbot added a project: Patch-For-Review.Feb 14 2020, 3:15 PM
gerritbot added a comment.Feb 14 2020, 3:18 PM

Change 572258 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] SpecialInvestigate: Remove browser autocomplete from target widget

https://gerrit.wikimedia.org/r/572258

gerritbot added a comment.Feb 14 2020, 6:32 PM

Change 572254 merged by jenkins-bot:
[mediawiki/core@master] HTMLUsersMultiselectField: Pass through config for widget's input

https://gerrit.wikimedia.org/r/572254

gerritbot added a comment.Feb 14 2020, 6:33 PM

Change 572258 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] SpecialInvestigate: Remove browser autocomplete from target widget

https://gerrit.wikimedia.org/r/572258

Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.Feb 14 2020, 6:44 PM
Niharika subscribed.

@Tchanders Should we move this to Done?

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Feb 14 2020, 6:45 PM
Tchanders moved this task from QA/Testing 🐞 to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.
Tchanders added a subscriber: dmaza.

@Niharika Good idea. @dmaza and I have tested, I think that should be enough for such a small change

Tchanders closed this task as Resolved.Feb 14 2020, 6:47 PM
Tchanders claimed this task.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 14 2020, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 14 2020, 7:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits