Page MenuHomePhabricator

Prevent browser autocomplete in the UsersMultiselectWidget in Special:Investigate
Closed, ResolvedPublic

Description

The HTMLTitlesMultiselectField passes input config through to the TitlesMultiselectWidget, allowing 'autocomplete' to be set to false. Do the same for the UsersMultiselectWidget.

(In the longer term, but beyond the scope of this task, these fields should be refactored to share more to reduce the need for duplication.)

Details

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Feb 14, 2:00 PM

Change 572254 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] HTMLUsersMultiselectField: Pass through config for widget's input

https://gerrit.wikimedia.org/r/572254

Change 572258 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] SpecialInvestigate: Remove browser autocomplete from target widget

https://gerrit.wikimedia.org/r/572258

Change 572254 merged by jenkins-bot:
[mediawiki/core@master] HTMLUsersMultiselectField: Pass through config for widget's input

https://gerrit.wikimedia.org/r/572254

Change 572258 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] SpecialInvestigate: Remove browser autocomplete from target widget

https://gerrit.wikimedia.org/r/572258

Niharika added a subscriber: Niharika.

@Tchanders Should we move this to Done?

Tchanders added a subscriber: dmaza.

@Niharika Good idea. @dmaza and I have tested, I think that should be enough for such a small change

Tchanders closed this task as Resolved.Fri, Feb 14, 6:47 PM
Tchanders claimed this task.