Page MenuHomePhabricator

108: Move the settings from global.js to personal json page.
Closed, DeclinedPublicFeature

Description

Hi. I do not think it's a good idea to edit automatically the personal global.js page. It is error prone. I can show you one big mistake that it did some time ago, but my purpose is not to fix this concrete problem, but remove the settings from there at all. Also, using windows.* variables should be minimized. Much better idea is usage of personal json page. I've already wrote all the code for this process, for watchlist page and for settings page, and can share it if you're interested. Thank you.

Event Timeline

Restricted Application added a subscriber: DannyS712. · View Herald Transcript
IKhitron changed the subtype of this task from "Task" to "Feature Request".Feb 14 2020, 8:17 PM
Masumrezarock100 subscribed.

Marking as declined in favor of T238299 per comments in T237082#5680479. I agree with making the settings not public. Setting up a global preference would be better.

Marking as declined in favor of T238299 per comments in T237082#5680479. I agree with making the settings not public. Setting up a global preference would be better.

A pity. I do not care about publicity. But the problems I've described are still there.

DannyS712 renamed this task from Move the settings from global.js to personal json page. to 108: Move the settings from global.js to personal json page..Feb 14 2020, 11:46 PM

A pity. I do not care about publicity. But the problems I've described are still there.

I mean local watchlist preferences are private, and GW is a "watchlist". Some prefer not making their settings public. Storing it as global-preferences is one way to hide them from public. But it seems Danny haven't had the time to work on that yet.
My points in T237082 is still valid. Especially this one.

  • GlobalWatchlist.js is optimized for mobile. But global modules are not currently loaded in mobile. So mobileusers can not set their preferences unless they set it manually in their minerva.js/mobile.js

I have to maintain two config files of GW to make it work on mobile.
You said you already wrote the code for this task. I wonder if @DannyS712 wants to reconsider this for the time being. I don't see any cons here. Making another getJSON call isn't hard and not expensive considering GW loads much more huge pile of data when actually loading the watchlist.